* gpio-sx150x.c build error
@ 2015-01-21 9:29 Mike Krinkin
2015-01-22 3:02 ` Alexandre Courbot
0 siblings, 1 reply; 2+ messages in thread
From: Mike Krinkin @ 2015-01-21 9:29 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel
Hello,
i failed to build linux-next for 20 Jan, because of the following build error:
drivers/gpio/gpio-sx150x.c:487:17: error: ‘struct gpio_chip’ has no member named ‘of_node’
chip->gpio_chip.of_node = client->dev.of_node;
^
drivers/gpio/gpio-sx150x.c:488:17: error: ‘struct gpio_chip’ has no member named ‘of_gpio_n_cells’
chip->gpio_chip.of_gpio_n_cells = 2;
^
make[2]: *** [drivers/gpio/gpio-sx150x.o] Error 1
make[1]: *** [drivers/gpio] Error 2
make: *** [drivers] Error 2
This change introduced by Wei Chen commit 04d2264c3bf0 ("gpio: sx150x: add dts
support for sx150x driver"). Maybe `#ifndef CONFIG_OF_GPIO` should be here?
FIY: i don't use this gpio, just happened to notice, and i have disabled this
in my config.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: gpio-sx150x.c build error
2015-01-21 9:29 gpio-sx150x.c build error Mike Krinkin
@ 2015-01-22 3:02 ` Alexandre Courbot
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Courbot @ 2015-01-22 3:02 UTC (permalink / raw)
To: Mike Krinkin, Wei Chen
Cc: Linus Walleij, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
On Wed, Jan 21, 2015 at 6:29 PM, Mike Krinkin <krinkin.m.u@gmail.com> wrote:
> Hello,
>
> i failed to build linux-next for 20 Jan, because of the following build error:
>
> drivers/gpio/gpio-sx150x.c:487:17: error: ‘struct gpio_chip’ has no member named ‘of_node’
> chip->gpio_chip.of_node = client->dev.of_node;
> ^
> drivers/gpio/gpio-sx150x.c:488:17: error: ‘struct gpio_chip’ has no member named ‘of_gpio_n_cells’
> chip->gpio_chip.of_gpio_n_cells = 2;
> ^
> make[2]: *** [drivers/gpio/gpio-sx150x.o] Error 1
> make[1]: *** [drivers/gpio] Error 2
> make: *** [drivers] Error 2
>
> This change introduced by Wei Chen commit 04d2264c3bf0 ("gpio: sx150x: add dts
> support for sx150x driver"). Maybe `#ifndef CONFIG_OF_GPIO` should be here?
>
> FIY: i don't use this gpio, just happened to notice, and i have disabled this
> in my config.
Adding Wei. Could you have a look at this and send a fixup patch?
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-22 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-21 9:29 gpio-sx150x.c build error Mike Krinkin
2015-01-22 3:02 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).