Re: [PATCH 1/3] gpio: Add new flags to control sleep status of GPIOs

[Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On Tue, 23 May 2017, Linus Walleij wrote:

> On Tue, May 16, 2017 at 5:31 PM, Charles Keepax
> <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
> 
> > Add new flags to allow users to specify that they are not concerned with
> > the status of GPIOs whilst in a sleep/low power state.
> >
> > Signed-off-by: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> 
> Would be nice to have some opinion from the DT maintainers about
> this but seems all right to me.

Not sure if it makes a difference, but Rob Acked the bindings already.

> > +++ b/include/dt-bindings/gpio/gpio.h
> > @@ -21,6 +21,10 @@
> >  #define GPIO_LINE_OPEN_SOURCE 0
> >  #define GPIO_LINE_OPEN_DRAIN 4
> >
> > +/* Bit 3 express GPIO suspend/resume persistence */
> > +#define GPIO_SLEEP_MAINTAIN_VALUE 0
> > +#define GPIO_SLEEP_MAY_LOOSE_VALUE 8
> > +
> >  /*
> >   * Open Drain/Collector is the combination of single-ended open drain interface.
> >   * Open Source/Emitter is the combination of single-ended open source interface.
> 
> Please move the define below the comment and macros below it,
> that is using the defines right above...
> 
> Yours,
> Linus Walleij

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html