* [PATCH] gpio-wm831x: Use seq_putc() in wm831x_gpio_dbg_show()
@ 2018-01-12 20:37 SF Markus Elfring
2018-01-15 10:03 ` Charles Keepax
2018-02-06 13:29 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-01-12 20:37 UTC (permalink / raw)
To: linux-gpio, patches, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 21:30:09 +0100
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpio/gpio-wm831x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c
index 938bbe3f831c..324813e8304e 100644
--- a/drivers/gpio/gpio-wm831x.c
+++ b/drivers/gpio/gpio-wm831x.c
@@ -182,7 +182,7 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
dev_err(wm831x->dev,
"GPIO control %d read failed: %d\n",
gpio, reg);
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
continue;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio-wm831x: Use seq_putc() in wm831x_gpio_dbg_show()
2018-01-12 20:37 [PATCH] gpio-wm831x: Use seq_putc() in wm831x_gpio_dbg_show() SF Markus Elfring
@ 2018-01-15 10:03 ` Charles Keepax
2018-02-06 13:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2018-01-15 10:03 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-gpio, patches, Linus Walleij, LKML, kernel-janitors
On Fri, Jan 12, 2018 at 09:37:53PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 12 Jan 2018 21:30:09 +0100
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio-wm831x: Use seq_putc() in wm831x_gpio_dbg_show()
2018-01-12 20:37 [PATCH] gpio-wm831x: Use seq_putc() in wm831x_gpio_dbg_show() SF Markus Elfring
2018-01-15 10:03 ` Charles Keepax
@ 2018-02-06 13:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-02-06 13:29 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, patches, LKML, kernel-janitors
On Fri, Jan 12, 2018 at 9:37 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 12 Jan 2018 21:30:09 +0100
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied with Charles' ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-06 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 20:37 [PATCH] gpio-wm831x: Use seq_putc() in wm831x_gpio_dbg_show() SF Markus Elfring
2018-01-15 10:03 ` Charles Keepax
2018-02-06 13:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox