Linux GPIO subsystem development
 help / color / mirror / Atom feed
* [gpio:devel 68/75] drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon
@ 2018-01-17  2:34 kbuild test robot
  2018-01-17  2:34 ` [PATCH] gpio: stmpe: fix semicolon.cocci warnings kbuild test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-01-17  2:34 UTC (permalink / raw)
  To: Patrice Chotard; +Cc: kbuild-all, linux-gpio, Linus Walleij, Alexandre TORGUE

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git devel
head:   c187aa4e21c3b2ffd13d7117baee722b7435244f
commit: bb628176dbc5e84ce958f609bbd42ae859b39d07 [68/75] gpio: stmpe: i2c transfer are forbiden in atomic context


coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] gpio: stmpe: fix semicolon.cocci warnings
  2018-01-17  2:34 [gpio:devel 68/75] drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon kbuild test robot
@ 2018-01-17  2:34 ` kbuild test robot
  2018-01-17  8:26   ` Patrice CHOTARD
  2018-01-17  9:21   ` Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: kbuild test robot @ 2018-01-17  2:34 UTC (permalink / raw)
  To: Patrice Chotard; +Cc: kbuild-all, linux-gpio, Linus Walleij, Alexandre TORGUE

From: Fengguang Wu <fengguang.wu@intel.com>

drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: bb628176dbc5 ("gpio: stmpe: i2c transfer are forbiden in atomic context")
CC: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 gpio-stmpe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpio/gpio-stmpe.c
+++ b/drivers/gpio/gpio-stmpe.c
@@ -198,7 +198,7 @@ static void stmpe_gpio_irq_sync_unlock(s
 	if (stmpe->partnum == STMPE1600) {
 		stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_GPMR_LSB]);
 		stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_GPMR_CSB]);
-	};
+	}
 
 	for (i = 0; i < CACHE_NR_REGS; i++) {
 		/* STMPE801 and STMPE1600 don't have RE and FE registers */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: stmpe: fix semicolon.cocci warnings
  2018-01-17  2:34 ` [PATCH] gpio: stmpe: fix semicolon.cocci warnings kbuild test robot
@ 2018-01-17  8:26   ` Patrice CHOTARD
  2018-01-17  9:21   ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2018-01-17  8:26 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all@01.org, linux-gpio@vger.kernel.org, Linus Walleij,
	Alexandre TORGUE

Hi Fengguang

On 01/17/2018 03:34 AM, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon
> 
> 
>   Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: bb628176dbc5 ("gpio: stmpe: i2c transfer are forbiden in atomic context")
> CC: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>   gpio-stmpe.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/gpio/gpio-stmpe.c
> +++ b/drivers/gpio/gpio-stmpe.c
> @@ -198,7 +198,7 @@ static void stmpe_gpio_irq_sync_unlock(s
>   	if (stmpe->partnum == STMPE1600) {
>   		stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_GPMR_LSB]);
>   		stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_GPMR_CSB]);
> -	};
> +	}
>   
>   	for (i = 0; i < CACHE_NR_REGS; i++) {
>   		/* STMPE801 and STMPE1600 don't have RE and FE registers */
> 

Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: stmpe: fix semicolon.cocci warnings
  2018-01-17  2:34 ` [PATCH] gpio: stmpe: fix semicolon.cocci warnings kbuild test robot
  2018-01-17  8:26   ` Patrice CHOTARD
@ 2018-01-17  9:21   ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-01-17  9:21 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Patrice Chotard, kbuild-all, linux-gpio, Alexandre TORGUE

On Wed, Jan 17, 2018 at 3:34 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:

> From: Fengguang Wu <fengguang.wu@intel.com>
>
> drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: bb628176dbc5 ("gpio: stmpe: i2c transfer are forbiden in atomic context")
> CC: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

I just edited the offending commit, thanks!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-17  9:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17  2:34 [gpio:devel 68/75] drivers/gpio/gpio-stmpe.c:201:2-3: Unneeded semicolon kbuild test robot
2018-01-17  2:34 ` [PATCH] gpio: stmpe: fix semicolon.cocci warnings kbuild test robot
2018-01-17  8:26   ` Patrice CHOTARD
2018-01-17  9:21   ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox