From: Chen Zhou <chenzhou10@huawei.com>
To: <tomasz.figa@gmail.com>, <krzk@kernel.org>, <s.nawrocki@samsung.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chenzhou10@huawei.com>, Hulk Robot <hulkci@huawei.com>
Subject: [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO
Date: Thu, 12 Dec 2019 17:21:36 +0800 [thread overview]
Message-ID: <20191212092136.37870-1-chenzhou10@huawei.com> (raw)
If CONFIG_OF_GPIO is n, build fails:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register:
drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node
gc->of_node = bank->of_node;
Use #ifdef to guard this.
Reported-by: Hulk Robot <hulkci@huawei.com>Fixes
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index f26574e..5c29ad8 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -966,7 +966,9 @@ static int samsung_gpiolib_register(struct platform_device *pdev,
gc->base = bank->grange.base;
gc->ngpio = bank->nr_pins;
gc->parent = &pdev->dev;
+#ifdef CONFIG_OF_GPIO
gc->of_node = bank->of_node;
+#endif
gc->label = bank->name;
ret = devm_gpiochip_add_data(&pdev->dev, gc, bank);
--
2.7.4
next reply other threads:[~2019-12-12 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 9:21 Chen Zhou [this message]
2019-12-12 9:27 ` [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO Chen Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212092136.37870-1-chenzhou10@huawei.com \
--to=chenzhou10@huawei.com \
--cc=hulkci@huawei.com \
--cc=krzk@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox