* [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO
@ 2019-12-12 9:21 Chen Zhou
2019-12-12 9:27 ` Chen Zhou
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2019-12-12 9:21 UTC (permalink / raw)
To: tomasz.figa, krzk, s.nawrocki
Cc: linux-gpio, linux-kernel, chenzhou10, Hulk Robot
If CONFIG_OF_GPIO is n, build fails:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register:
drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node
gc->of_node = bank->of_node;
Use #ifdef to guard this.
Reported-by: Hulk Robot <hulkci@huawei.com>Fixes
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index f26574e..5c29ad8 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -966,7 +966,9 @@ static int samsung_gpiolib_register(struct platform_device *pdev,
gc->base = bank->grange.base;
gc->ngpio = bank->nr_pins;
gc->parent = &pdev->dev;
+#ifdef CONFIG_OF_GPIO
gc->of_node = bank->of_node;
+#endif
gc->label = bank->name;
ret = devm_gpiochip_add_data(&pdev->dev, gc, bank);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO
2019-12-12 9:21 [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO Chen Zhou
@ 2019-12-12 9:27 ` Chen Zhou
0 siblings, 0 replies; 2+ messages in thread
From: Chen Zhou @ 2019-12-12 9:27 UTC (permalink / raw)
To: tomasz.figa, krzk, s.nawrocki; +Cc: linux-gpio, linux-kernel, Hulk Robot
ignore this patch, i will repost it.
On 2019/12/12 17:21, Chen Zhou wrote:
> If CONFIG_OF_GPIO is n, build fails:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register:
> drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node
> gc->of_node = bank->of_node;
>
> Use #ifdef to guard this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>Fixes
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index f26574e..5c29ad8 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -966,7 +966,9 @@ static int samsung_gpiolib_register(struct platform_device *pdev,
> gc->base = bank->grange.base;
> gc->ngpio = bank->nr_pins;
> gc->parent = &pdev->dev;
> +#ifdef CONFIG_OF_GPIO
> gc->of_node = bank->of_node;
> +#endif
> gc->label = bank->name;
>
> ret = devm_gpiochip_add_data(&pdev->dev, gc, bank);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-12 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12 9:21 [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF_GPIO Chen Zhou
2019-12-12 9:27 ` Chen Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox