From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/4] pinctrl: intel: Convert revision conditional to switch-case
Date: Thu, 7 Jan 2021 21:01:59 +0200 [thread overview]
Message-ID: <20210107190200.41221-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20210107190200.41221-1-andriy.shevchenko@linux.intel.com>
switch-case is slightly better to maintain in case some new features will come
in new revisions of the hardware.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 1a479112ed85..00979acb0203 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1483,9 +1483,13 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
/* Determine community features based on the revision */
value = readl(regs + REVID);
- if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) {
+ switch ((value & REVID_MASK) >> REVID_SHIFT) {
+ case 0x0094 ... 0xffff:
community->features |= PINCTRL_FEATURE_DEBOUNCE;
community->features |= PINCTRL_FEATURE_1K_PD;
+ break;
+ default:
+ break;
}
/* Read offset of the pad configuration registers */
--
2.29.2
next prev parent reply other threads:[~2021-01-07 19:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 19:01 [PATCH v1 1/4] pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance Andy Shevchenko
2021-01-07 19:01 ` [PATCH v1 2/4] pinctrl: intel: Drop unnecessary check for predefined features Andy Shevchenko
2021-01-08 7:08 ` Mika Westerberg
2021-01-07 19:01 ` Andy Shevchenko [this message]
2021-01-08 7:05 ` [PATCH v1 3/4] pinctrl: intel: Convert revision conditional to switch-case Mika Westerberg
2021-01-07 19:02 ` [PATCH v1 4/4] pinctrl: intel: Convert capability list to features Andy Shevchenko
2021-01-08 7:07 ` Mika Westerberg
2021-01-08 12:22 ` Andy Shevchenko
2021-01-08 12:31 ` Andy Shevchenko
2021-01-08 12:46 ` Mika Westerberg
2021-01-08 12:51 ` Andy Shevchenko
2021-01-08 13:11 ` Mika Westerberg
2021-01-08 13:45 ` Andy Shevchenko
2021-01-08 7:07 ` [PATCH v1 1/4] pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107190200.41221-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox