* [PATCH] pinctrl: actions: Add the platform dependency to drivers
@ 2021-01-21 6:25 Manivannan Sadhasivam
2021-01-22 13:19 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-01-21 6:25 UTC (permalink / raw)
To: linus.walleij
Cc: afaerber, linux-arm-kernel, linux-actions, linux-gpio,
linux-kernel, cristian.ciocaltea, Manivannan Sadhasivam
The Actions Semi pinctrl drivers are a mix of both ARM32 and ARM64
platforms. So let's add the correct platform dependency to avoid them
being selected on the other.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/pinctrl/actions/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/actions/Kconfig b/drivers/pinctrl/actions/Kconfig
index a1d16e8280e5..8bb8345b17da 100644
--- a/drivers/pinctrl/actions/Kconfig
+++ b/drivers/pinctrl/actions/Kconfig
@@ -12,18 +12,21 @@ config PINCTRL_OWL
config PINCTRL_S500
bool "Actions Semi S500 pinctrl driver"
+ depends on ARM
depends on PINCTRL_OWL
help
Say Y here to enable Actions Semi S500 pinctrl driver
config PINCTRL_S700
bool "Actions Semi S700 pinctrl driver"
+ depends on ARM64
depends on PINCTRL_OWL
help
Say Y here to enable Actions Semi S700 pinctrl driver
config PINCTRL_S900
bool "Actions Semi S900 pinctrl driver"
+ depends on ARM64
depends on PINCTRL_OWL
help
Say Y here to enable Actions Semi S900 pinctrl driver
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: actions: Add the platform dependency to drivers
2021-01-21 6:25 [PATCH] pinctrl: actions: Add the platform dependency to drivers Manivannan Sadhasivam
@ 2021-01-22 13:19 ` Linus Walleij
2021-01-22 13:51 ` Manivannan Sadhasivam
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2021-01-22 13:19 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Andreas Färber, Linux ARM, linux-actions,
open list:GPIO SUBSYSTEM, linux-kernel@vger.kernel.org,
Cristian Ciocaltea
On Thu, Jan 21, 2021 at 7:26 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
> The Actions Semi pinctrl drivers are a mix of both ARM32 and ARM64
> platforms. So let's add the correct platform dependency to avoid them
> being selected on the other.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Are you not opting out of build tests when you do this?
What about:
depends on ARM64 || COMPILE_TEST
(etc)
?
Yours,
Linus Walleij
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: actions: Add the platform dependency to drivers
2021-01-22 13:19 ` Linus Walleij
@ 2021-01-22 13:51 ` Manivannan Sadhasivam
0 siblings, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-01-22 13:51 UTC (permalink / raw)
To: Linus Walleij
Cc: Andreas Färber, Linux ARM, linux-actions,
open list:GPIO SUBSYSTEM, linux-kernel@vger.kernel.org,
Cristian Ciocaltea
On Fri, Jan 22, 2021 at 02:19:07PM +0100, Linus Walleij wrote:
> On Thu, Jan 21, 2021 at 7:26 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
>
> > The Actions Semi pinctrl drivers are a mix of both ARM32 and ARM64
> > platforms. So let's add the correct platform dependency to avoid them
> > being selected on the other.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Are you not opting out of build tests when you do this?
>
> What about:
>
> depends on ARM64 || COMPILE_TEST
> (etc)
> ?
>
Oh yeah, I missed it. Will send v2.
Thanks,
Mani
> Yours,
> Linus Walleij
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-22 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-21 6:25 [PATCH] pinctrl: actions: Add the platform dependency to drivers Manivannan Sadhasivam
2021-01-22 13:19 ` Linus Walleij
2021-01-22 13:51 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox