* [PATCH] pinctrl: ocelot: fix confops resource index
@ 2022-02-16 8:20 Michael Walle
2022-02-16 15:37 ` Colin Foster
2022-03-15 0:05 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2022-02-16 8:20 UTC (permalink / raw)
To: Linus Walleij, Colin Foster; +Cc: linux-gpio, linux-kernel, Michael Walle
Prior to commit ad96111e658a ("pinctrl: ocelot: combine get resource and
ioremap into single call") the resource index was 1, now it is 0. But 0
is the base region for the pinctrl block. Fix it.
I noticed this because there was an error that the memory region was
ioremapped twice.
Fixes: ad96111e658a ("pinctrl: ocelot: combine get resource and ioremap into single call")
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/pinctrl/pinctrl-ocelot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
index 685c79e08d40..a859fbcb09af 100644
--- a/drivers/pinctrl/pinctrl-ocelot.c
+++ b/drivers/pinctrl/pinctrl-ocelot.c
@@ -1892,7 +1892,7 @@ static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
.max_register = 32,
};
- base = devm_platform_ioremap_resource(pdev, 0);
+ base = devm_platform_ioremap_resource(pdev, 1);
if (IS_ERR(base)) {
dev_dbg(&pdev->dev, "Failed to ioremap config registers (no extended pinconf)\n");
return NULL;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: ocelot: fix confops resource index
2022-02-16 8:20 [PATCH] pinctrl: ocelot: fix confops resource index Michael Walle
@ 2022-02-16 15:37 ` Colin Foster
2022-03-15 0:05 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Colin Foster @ 2022-02-16 15:37 UTC (permalink / raw)
To: Michael Walle; +Cc: Linus Walleij, linux-gpio, linux-kernel
Hi Michael,
On Wed, Feb 16, 2022 at 09:20:20AM +0100, Michael Walle wrote:
> Prior to commit ad96111e658a ("pinctrl: ocelot: combine get resource and
> ioremap into single call") the resource index was 1, now it is 0. But 0
> is the base region for the pinctrl block. Fix it.
> I noticed this because there was an error that the memory region was
> ioremapped twice.
My apologies... I missed this and didn't have access to hardware to
test. Thanks for the fix.
Reviewed-by: Colin Foster <colin.foster@in-advantage.com>
>
> Fixes: ad96111e658a ("pinctrl: ocelot: combine get resource and ioremap into single call")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> drivers/pinctrl/pinctrl-ocelot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index 685c79e08d40..a859fbcb09af 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -1892,7 +1892,7 @@ static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
> .max_register = 32,
> };
>
> - base = devm_platform_ioremap_resource(pdev, 0);
> + base = devm_platform_ioremap_resource(pdev, 1);
> if (IS_ERR(base)) {
> dev_dbg(&pdev->dev, "Failed to ioremap config registers (no extended pinconf)\n");
> return NULL;
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: ocelot: fix confops resource index
2022-02-16 8:20 [PATCH] pinctrl: ocelot: fix confops resource index Michael Walle
2022-02-16 15:37 ` Colin Foster
@ 2022-03-15 0:05 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-03-15 0:05 UTC (permalink / raw)
To: Michael Walle; +Cc: Colin Foster, linux-gpio, linux-kernel
On Wed, Feb 16, 2022 at 9:20 AM Michael Walle <michael@walle.cc> wrote:
> Prior to commit ad96111e658a ("pinctrl: ocelot: combine get resource and
> ioremap into single call") the resource index was 1, now it is 0. But 0
> is the base region for the pinctrl block. Fix it.
> I noticed this because there was an error that the memory region was
> ioremapped twice.
>
> Fixes: ad96111e658a ("pinctrl: ocelot: combine get resource and ioremap into single call")
> Signed-off-by: Michael Walle <michael@walle.cc>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 0:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-16 8:20 [PATCH] pinctrl: ocelot: fix confops resource index Michael Walle
2022-02-16 15:37 ` Colin Foster
2022-03-15 0:05 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox