Re: [libgpiod v2][PATCH] treewide: implement v2 API

Re: [libgpiod v2][PATCH] treewide: implement v2 API

[Kent Gibson]

On Thu, Jun 02, 2022 at 01:26:56PM +0200, Bartosz Golaszewski wrote:
> This is the main changeset implementing the new libgpiod API for the core
> C library as well as C++ and Python bindings. It's actually the effect of
> squashing all the patches we've had in the next/libgpiod-v2.0 branch (and
> that have been developed and reviewed over the course of several months)
> so that the master branch can remain bisectable.
> 
> Big thanks to Kent Gibson for his reviews.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> [Ben: fix format specifier for uint64_t]
> Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
> [Viresh: Fix ioctl number for gpiod_line_request_reconfigure_lines()]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> [Kent: splitting of chip_info out of chip, documentation tweaks and some renaming]
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
> There were no reviews so far for the python bindings but I'm generally
> happy with them and think that the contents of next/libgpiod-2.0 branch
> are mature enough to get them into master and continue the work incrementally
> there. So this is the amalgamation of all the work done so far on libgpiod v2
> that I'd like to apply soon.
> 

My apologies for not getting back to you earlier wrt the python
bindings.
When I try them I get:

$ python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import gpiod
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "exception.c", line 1, in <module>
NameError: __build_class__ not found
>>>

I may be doing something dopey, but building v1.6.3 on the same
platform (a clean Debian 11.3 install with a v5.18 kernel with gpiosim
and gpio-mockup) works fine.
Haven't had a chance to look into it further...

Any ideas?

Cheers,
Kent.

Re: [libgpiod v2][PATCH] treewide: implement v2 API

[Bartosz Golaszewski]

On Thu, Jun 2, 2022 at 1:52 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Thu, Jun 02, 2022 at 01:26:56PM +0200, Bartosz Golaszewski wrote:
> > This is the main changeset implementing the new libgpiod API for the core
> > C library as well as C++ and Python bindings. It's actually the effect of
> > squashing all the patches we've had in the next/libgpiod-v2.0 branch (and
> > that have been developed and reviewed over the course of several months)
> > so that the master branch can remain bisectable.
> >
> > Big thanks to Kent Gibson for his reviews.
> >
> > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> > [Ben: fix format specifier for uint64_t]
> > Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
> > [Viresh: Fix ioctl number for gpiod_line_request_reconfigure_lines()]
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > [Kent: splitting of chip_info out of chip, documentation tweaks and some renaming]
> > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > ---
> > There were no reviews so far for the python bindings but I'm generally
> > happy with them and think that the contents of next/libgpiod-2.0 branch
> > are mature enough to get them into master and continue the work incrementally
> > there. So this is the amalgamation of all the work done so far on libgpiod v2
> > that I'd like to apply soon.
> >
>
> My apologies for not getting back to you earlier wrt the python
> bindings.
> When I try them I get:
>
> $ python3
> Python 3.9.2 (default, Feb 28 2021, 17:03:44)
> [GCC 10.2.1 20210110] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import gpiod
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "exception.c", line 1, in <module>
> NameError: __build_class__ not found
> >>>
>
> I may be doing something dopey, but building v1.6.3 on the same
> platform (a clean Debian 11.3 install with a v5.18 kernel with gpiosim
> and gpio-mockup) works fine.
> Haven't had a chance to look into it further...
>
> Any ideas?

I ran Debian 11.3 with docker and can confirm this issue. I don't see
it on Ubuntu 22.04. Interesting. I'll look into it.

Bart