Linux GPIO subsystem development
 help / color / mirror / Atom feed
* [libgpiod][PATCH v2] bindings: rust: fix documentation of line_request set_values
@ 2023-01-16 12:51 Kent Gibson
  2023-01-16 13:54 ` Bartosz Golaszewski
  0 siblings, 1 reply; 2+ messages in thread
From: Kent Gibson @ 2023-01-16 12:51 UTC (permalink / raw)
  To: linux-gpio, brgl; +Cc: Kent Gibson

Replace "Get" with "Set".

Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
Changes v1 -> v2:
 - rebase on current master

 bindings/rust/libgpiod/src/line_request.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs
index c16ec9f..d9e041c 100644
--- a/bindings/rust/libgpiod/src/line_request.rs
+++ b/bindings/rust/libgpiod/src/line_request.rs
@@ -106,7 +106,7 @@ impl Request {
         }
     }
 
-    /// Get values of a subset of lines associated with the request.
+    /// Set values of a subset of lines associated with the request.
     pub fn set_values_subset(&self, map: ValueMap) -> Result<()> {
         let mut offsets = Vec::new();
         let mut values = Vec::new();
@@ -136,7 +136,7 @@ impl Request {
         }
     }
 
-    /// Get values of all lines associated with the request.
+    /// Set values of all lines associated with the request.
     pub fn set_values(&self, values: &[Value]) -> Result<()> {
         if values.len() != self.num_lines() as usize {
             return Err(Error::InvalidArguments);
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [libgpiod][PATCH v2] bindings: rust: fix documentation of line_request set_values
  2023-01-16 12:51 [libgpiod][PATCH v2] bindings: rust: fix documentation of line_request set_values Kent Gibson
@ 2023-01-16 13:54 ` Bartosz Golaszewski
  0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-01-16 13:54 UTC (permalink / raw)
  To: Kent Gibson; +Cc: linux-gpio

On Mon, Jan 16, 2023 at 1:51 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> Replace "Get" with "Set".
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
> Changes v1 -> v2:
>  - rebase on current master
>
>  bindings/rust/libgpiod/src/line_request.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs
> index c16ec9f..d9e041c 100644
> --- a/bindings/rust/libgpiod/src/line_request.rs
> +++ b/bindings/rust/libgpiod/src/line_request.rs
> @@ -106,7 +106,7 @@ impl Request {
>          }
>      }
>
> -    /// Get values of a subset of lines associated with the request.
> +    /// Set values of a subset of lines associated with the request.
>      pub fn set_values_subset(&self, map: ValueMap) -> Result<()> {
>          let mut offsets = Vec::new();
>          let mut values = Vec::new();
> @@ -136,7 +136,7 @@ impl Request {
>          }
>      }
>
> -    /// Get values of all lines associated with the request.
> +    /// Set values of all lines associated with the request.
>      pub fn set_values(&self, values: &[Value]) -> Result<()> {
>          if values.len() != self.num_lines() as usize {
>              return Err(Error::InvalidArguments);
> --
> 2.39.0
>

Applied, thanks!

Bartosz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-16 13:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-16 12:51 [libgpiod][PATCH v2] bindings: rust: fix documentation of line_request set_values Kent Gibson
2023-01-16 13:54 ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox