From: Zhu Wang <wangzhu9@huawei.com>
To: <linus.walleij@linaro.org>, <brgl@bgdev.pl>, <andy@kernel.org>,
<linux-gpio@vger.kernel.org>, <andriy.shevchenko@linux.intel.com>
Cc: <wangzhu9@huawei.com>
Subject: [PATCH -next v2] gpio: tps65218: remove redundant of_match_ptr()
Date: Wed, 2 Aug 2023 11:52:37 +0800 [thread overview]
Message-ID: <20230802035237.177306-1-wangzhu9@huawei.com> (raw)
The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here.
Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it. Hence we remove of_match_ptr().
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Changes in v2:
- Change of_match_ptr to of_match_ptr() in the commit message.
---
drivers/gpio/gpio-tps65218.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
index e1d425a18854..da51aa5578eb 100644
--- a/drivers/gpio/gpio-tps65218.c
+++ b/drivers/gpio/gpio-tps65218.c
@@ -216,7 +216,7 @@ MODULE_DEVICE_TABLE(platform, tps65218_gpio_id_table);
static struct platform_driver tps65218_gpio_driver = {
.driver = {
.name = "tps65218-gpio",
- .of_match_table = of_match_ptr(tps65218_dt_match)
+ .of_match_table = tps65218_dt_match
},
.probe = tps65218_gpio_probe,
.id_table = tps65218_gpio_id_table,
--
2.17.1
next reply other threads:[~2023-08-02 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 3:52 Zhu Wang [this message]
2023-08-02 14:15 ` [PATCH -next v2] gpio: tps65218: remove redundant of_match_ptr() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802035237.177306-1-wangzhu9@huawei.com \
--to=wangzhu9@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox