[PATCH -next v2] gpio: tps65218: remove redundant of_match_ptr()

[PATCH -next v2] gpio: tps65218: remove redundant of_match_ptr()

[Zhu Wang]

The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it. Hence we remove of_match_ptr().

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

---
Changes in v2:
- Change of_match_ptr to of_match_ptr() in the commit message.
---
 drivers/gpio/gpio-tps65218.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
index e1d425a18854..da51aa5578eb 100644
--- a/drivers/gpio/gpio-tps65218.c
+++ b/drivers/gpio/gpio-tps65218.c
@@ -216,7 +216,7 @@ MODULE_DEVICE_TABLE(platform, tps65218_gpio_id_table);
 static struct platform_driver tps65218_gpio_driver = {
 	.driver = {
 		.name = "tps65218-gpio",
-		.of_match_table = of_match_ptr(tps65218_dt_match)
+		.of_match_table = tps65218_dt_match
 	},
 	.probe = tps65218_gpio_probe,
 	.id_table = tps65218_gpio_id_table,
-- 
2.17.1

Re: [PATCH -next v2] gpio: tps65218: remove redundant of_match_ptr()

[Andy Shevchenko]

On Wed, Aug 2, 2023 at 6:53 AM Zhu Wang <wangzhu9@huawei.com> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr().

...

>         .driver = {
>                 .name = "tps65218-gpio",
> -               .of_match_table = of_match_ptr(tps65218_dt_match)
> +               .of_match_table = tps65218_dt_match

Sorry, haven't seen it before, but it's good to add a trailing comma
here, while you are touching this line. Perhaps no resending needed
and Bart can amend when applying.

>         },


-- 
With Best Regards,
Andy Shevchenko