* [PATCH v1 1/1] gpiolib: swnode: Remove wrong header inclusion
@ 2024-04-17 14:19 Andy Shevchenko
2024-04-17 20:48 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2024-04-17 14:19 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Charles Keepax
The flags in the software node properties are supposed to be
the GPIO lookup flags, which are provided by gpio/machine.h,
as the software nodes are the kernel internal thing and doesn't
need to rely to any of ABIs.
Fixes: e7f9ff5dc90c ("gpiolib: add support for software nodes")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/gpio/property.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/gpio/property.h b/include/linux/gpio/property.h
index 6c75c8bd44a0..1a14e239221f 100644
--- a/include/linux/gpio/property.h
+++ b/include/linux/gpio/property.h
@@ -2,7 +2,6 @@
#ifndef __LINUX_GPIO_PROPERTY_H
#define __LINUX_GPIO_PROPERTY_H
-#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */
#include <linux/property.h>
#define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] gpiolib: swnode: Remove wrong header inclusion
2024-04-17 14:19 [PATCH v1 1/1] gpiolib: swnode: Remove wrong header inclusion Andy Shevchenko
@ 2024-04-17 20:48 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2024-04-17 20:48 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, linux-kernel, Linus Walleij, Charles Keepax
On Wed, Apr 17, 2024 at 4:19 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The flags in the software node properties are supposed to be
> the GPIO lookup flags, which are provided by gpio/machine.h,
> as the software nodes are the kernel internal thing and doesn't
> need to rely to any of ABIs.
>
> Fixes: e7f9ff5dc90c ("gpiolib: add support for software nodes")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/gpio/property.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/gpio/property.h b/include/linux/gpio/property.h
> index 6c75c8bd44a0..1a14e239221f 100644
> --- a/include/linux/gpio/property.h
> +++ b/include/linux/gpio/property.h
> @@ -2,7 +2,6 @@
> #ifndef __LINUX_GPIO_PROPERTY_H
> #define __LINUX_GPIO_PROPERTY_H
>
> -#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */
> #include <linux/property.h>
>
> #define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-17 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-17 14:19 [PATCH v1 1/1] gpiolib: swnode: Remove wrong header inclusion Andy Shevchenko
2024-04-17 20:48 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox