* [PATCH] pinctrl: th1520: add a CONFIG_OF dependency
@ 2024-10-15 15:11 Arnd Bergmann
2024-10-15 17:49 ` Drew Fustini
2024-10-15 21:39 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-10-15 15:11 UTC (permalink / raw)
To: Linus Walleij, Emil Renner Berthing, Drew Fustini
Cc: Arnd Bergmann, Andy Shevchenko, linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When compile-testing without CONfIG_OF:
drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]
455 | ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinconf_generic_dump_config
Enforce this using Kconig dependencies.
Fixes: bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index a6acc27c9a83..3fab5ebeb2e0 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -564,6 +564,7 @@ config PINCTRL_TPS6594
config PINCTRL_TH1520
tristate "Pinctrl driver for the T-Head TH1520 SoC"
depends on ARCH_THEAD || COMPILE_TEST
+ depends on OF
select GENERIC_PINMUX_FUNCTIONS
select GENERIC_PINCONF
select PINMUX
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: th1520: add a CONFIG_OF dependency
2024-10-15 15:11 [PATCH] pinctrl: th1520: add a CONFIG_OF dependency Arnd Bergmann
@ 2024-10-15 17:49 ` Drew Fustini
2024-10-15 21:39 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Drew Fustini @ 2024-10-15 17:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Emil Renner Berthing, Drew Fustini, Arnd Bergmann,
Andy Shevchenko, linux-gpio, linux-kernel
On Tue, Oct 15, 2024 at 03:11:13PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When compile-testing without CONfIG_OF:
>
> drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
> drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]
> 455 | ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | pinconf_generic_dump_config
>
> Enforce this using Kconig dependencies.
>
> Fixes: bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index a6acc27c9a83..3fab5ebeb2e0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -564,6 +564,7 @@ config PINCTRL_TPS6594
> config PINCTRL_TH1520
> tristate "Pinctrl driver for the T-Head TH1520 SoC"
> depends on ARCH_THEAD || COMPILE_TEST
> + depends on OF
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
> select PINMUX
> --
> 2.39.5
>
Thank you for fixing this.
Acked-by: Drew Fustini <drew@pdp7.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: th1520: add a CONFIG_OF dependency
2024-10-15 15:11 [PATCH] pinctrl: th1520: add a CONFIG_OF dependency Arnd Bergmann
2024-10-15 17:49 ` Drew Fustini
@ 2024-10-15 21:39 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2024-10-15 21:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Emil Renner Berthing, Drew Fustini, Arnd Bergmann,
Andy Shevchenko, linux-gpio, linux-kernel
On Tue, Oct 15, 2024 at 5:11 PM Arnd Bergmann <arnd@kernel.org> wrote:
> When compile-testing without CONfIG_OF:
>
> drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
> drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]
> 455 | ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | pinconf_generic_dump_config
>
> Enforce this using Kconig dependencies.
>
> Fixes: bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-15 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 15:11 [PATCH] pinctrl: th1520: add a CONFIG_OF dependency Arnd Bergmann
2024-10-15 17:49 ` Drew Fustini
2024-10-15 21:39 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox