* [libgpiod][PATCH] bindings: python: fix license tags
@ 2024-11-27 15:05 Bartosz Golaszewski
2024-11-27 15:10 ` [External] - " Vincent Fazio
2024-12-05 12:56 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-11-27 15:05 UTC (permalink / raw)
To: Vincent Fazio, Phil Howard, Kent Gibson, Linus Walleij
Cc: linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Several files under bindings/python/ have wrong license tags.
In general:
- Makefiles should be covered by GPL
- all python sources under bindings/python/gpiod/ and
bindings/python/tests/ that are part of importable modules should be
licensed under LGPL
- executable examples should be licensed under GPL
Reported-by: Vincent Fazio <vfazio@xes-inc.com>
Closes: https://github.com/brgl/libgpiod/issues/110
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Kent, Vincent:
This patch doesn't really relicense the code. It just makes the
licensing consistent across the python bindings. However - as the only
two authors of the affected files other than me - could you please leave
your acks?
bindings/python/gpiod/Makefile.am | 2 +-
bindings/python/gpiod/_internal.py | 2 +-
bindings/python/gpiod/ext/Makefile.am | 2 +-
bindings/python/tests/Makefile.am | 2 +-
bindings/python/tests/gpiosim/Makefile.am | 2 +-
bindings/python/tests/gpiosim/__init__.py | 2 +-
bindings/python/tests/helpers.py | 2 +-
bindings/python/tests/system/Makefile.am | 2 +-
bindings/python/tests/system/__init__.py | 2 +-
bindings/python/tests/tests_line.py | 2 +-
bindings/python/tests/tests_line_settings.py | 2 +-
11 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/bindings/python/gpiod/Makefile.am b/bindings/python/gpiod/Makefile.am
index 49addcc..7e37b8d 100644
--- a/bindings/python/gpiod/Makefile.am
+++ b/bindings/python/gpiod/Makefile.am
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
SUBDIRS = ext
diff --git a/bindings/python/gpiod/_internal.py b/bindings/python/gpiod/_internal.py
index c9b5d28..37f6661 100644
--- a/bindings/python/gpiod/_internal.py
+++ b/bindings/python/gpiod/_internal.py
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
from datetime import timedelta
diff --git a/bindings/python/gpiod/ext/Makefile.am b/bindings/python/gpiod/ext/Makefile.am
index 9c81b17..3a8a0d1 100644
--- a/bindings/python/gpiod/ext/Makefile.am
+++ b/bindings/python/gpiod/ext/Makefile.am
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
EXTRA_DIST = \
diff --git a/bindings/python/tests/Makefile.am b/bindings/python/tests/Makefile.am
index d6e3ea3..1809206 100644
--- a/bindings/python/tests/Makefile.am
+++ b/bindings/python/tests/Makefile.am
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
SUBDIRS = gpiosim system
diff --git a/bindings/python/tests/gpiosim/Makefile.am b/bindings/python/tests/gpiosim/Makefile.am
index b403f3c..cc8c11a 100644
--- a/bindings/python/tests/gpiosim/Makefile.am
+++ b/bindings/python/tests/gpiosim/Makefile.am
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
EXTRA_DIST = \
diff --git a/bindings/python/tests/gpiosim/__init__.py b/bindings/python/tests/gpiosim/__init__.py
index 64a1551..ddb59be 100644
--- a/bindings/python/tests/gpiosim/__init__.py
+++ b/bindings/python/tests/gpiosim/__init__.py
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
from .chip import Chip
diff --git a/bindings/python/tests/helpers.py b/bindings/python/tests/helpers.py
index 2126901..ad272a1 100644
--- a/bindings/python/tests/helpers.py
+++ b/bindings/python/tests/helpers.py
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
from __future__ import annotations
diff --git a/bindings/python/tests/system/Makefile.am b/bindings/python/tests/system/Makefile.am
index dbc8e64..3590be3 100644
--- a/bindings/python/tests/system/Makefile.am
+++ b/bindings/python/tests/system/Makefile.am
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
EXTRA_DIST = \
diff --git a/bindings/python/tests/system/__init__.py b/bindings/python/tests/system/__init__.py
index cba9b92..99fde9c 100644
--- a/bindings/python/tests/system/__init__.py
+++ b/bindings/python/tests/system/__init__.py
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
+# SPDX-License-Identifier: LGPL-2.1-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
from ._ext import check_kernel_version, set_process_name
diff --git a/bindings/python/tests/tests_line.py b/bindings/python/tests/tests_line.py
index c96f6de..5bc742a 100644
--- a/bindings/python/tests/tests_line.py
+++ b/bindings/python/tests/tests_line.py
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2024 Kent Gibson <warthog618@gmail.com>
from unittest import TestCase
diff --git a/bindings/python/tests/tests_line_settings.py b/bindings/python/tests/tests_line_settings.py
index 66e01df..ad70921 100644
--- a/bindings/python/tests/tests_line_settings.py
+++ b/bindings/python/tests/tests_line_settings.py
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1-or-later
+# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2022 Bartosz Golaszewski <brgl@bgdev.pl>
import datetime
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [External] - [libgpiod][PATCH] bindings: python: fix license tags
2024-11-27 15:05 [libgpiod][PATCH] bindings: python: fix license tags Bartosz Golaszewski
@ 2024-11-27 15:10 ` Vincent Fazio
2024-12-05 12:56 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Vincent Fazio @ 2024-11-27 15:10 UTC (permalink / raw)
To: Bartosz Golaszewski, Phil Howard, Kent Gibson, Linus Walleij
Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski
> -----Original Message-----
> From: Bartosz Golaszewski <brgl@bgdev.pl>
> Sent: Wednesday, November 27, 2024 9:05 AM
> To: Vincent Fazio <vfazio@xes-inc.com>; Phil Howard <phil@gadgetoid.com>;
> Kent Gibson <warthog618@gmail.com>; Linus Walleij
> <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org; Bartosz Golaszewski
> <bartosz.golaszewski@linaro.org>
> Subject: [External] - [libgpiod][PATCH] bindings: python: fix license tags
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Several files under bindings/python/ have wrong license tags.
>
> In general:
> - Makefiles should be covered by GPL
> - all python sources under bindings/python/gpiod/ and
> bindings/python/tests/ that are part of importable modules should be
> licensed under LGPL
> - executable examples should be licensed under GPL
>
> Reported-by: Vincent Fazio <vfazio@xes-inc.com>
> Closes: https://github.com/brgl/libgpiod/issues/110
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Kent, Vincent:
>
> This patch doesn't really relicense the code. It just makes the licensing
> consistent across the python bindings. However - as the only two authors of
> the affected files other than me - could you please leave your acks?
Acked-by: Vincent Fazio <vfazio@xes-inc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [libgpiod][PATCH] bindings: python: fix license tags
2024-11-27 15:05 [libgpiod][PATCH] bindings: python: fix license tags Bartosz Golaszewski
2024-11-27 15:10 ` [External] - " Vincent Fazio
@ 2024-12-05 12:56 ` Bartosz Golaszewski
2024-12-05 14:51 ` Kent Gibson
1 sibling, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-12-05 12:56 UTC (permalink / raw)
To: Vincent Fazio, Phil Howard, Kent Gibson, Linus Walleij,
Bartosz Golaszewski
Cc: Bartosz Golaszewski, linux-gpio
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Wed, 27 Nov 2024 16:05:29 +0100, Bartosz Golaszewski wrote:
> Several files under bindings/python/ have wrong license tags.
>
> In general:
> - Makefiles should be covered by GPL
> - all python sources under bindings/python/gpiod/ and
> bindings/python/tests/ that are part of importable modules should be
> licensed under LGPL
> - executable examples should be licensed under GPL
>
> [...]
I haven't heard from Kent but I doubt he would object so patch applied.
[1/1] bindings: python: fix license tags
commit: 6d9133a259e64da5e03c7e7784f0f27de7b3e59f
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [libgpiod][PATCH] bindings: python: fix license tags
2024-12-05 12:56 ` Bartosz Golaszewski
@ 2024-12-05 14:51 ` Kent Gibson
0 siblings, 0 replies; 4+ messages in thread
From: Kent Gibson @ 2024-12-05 14:51 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Vincent Fazio, Phil Howard, Linus Walleij, Bartosz Golaszewski,
linux-gpio
On Thu, Dec 05, 2024 at 01:56:48PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
>
> On Wed, 27 Nov 2024 16:05:29 +0100, Bartosz Golaszewski wrote:
> > Several files under bindings/python/ have wrong license tags.
> >
> > In general:
> > - Makefiles should be covered by GPL
> > - all python sources under bindings/python/gpiod/ and
> > bindings/python/tests/ that are part of importable modules should be
> > licensed under LGPL
> > - executable examples should be licensed under GPL
> >
> > [...]
>
> I haven't heard from Kent but I doubt he would object so patch applied.
>
Sorry - missed this one, but I have no objections.
Cheers,
Kent.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-05 14:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-27 15:05 [libgpiod][PATCH] bindings: python: fix license tags Bartosz Golaszewski
2024-11-27 15:10 ` [External] - " Vincent Fazio
2024-12-05 12:56 ` Bartosz Golaszewski
2024-12-05 14:51 ` Kent Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox