* [PATCH] pinctrl: spacemit: enable config option
@ 2025-02-07 12:11 Yixun Lan
2025-02-07 16:49 ` Conor Dooley
2025-02-07 18:00 ` Alex Elder
0 siblings, 2 replies; 6+ messages in thread
From: Yixun Lan @ 2025-02-07 12:11 UTC (permalink / raw)
To: Linus Walleij, Paul Walmsley, Palmer Dabbelt
Cc: Alex Elder, linux-riscv, linux-kernel, linux-gpio, spacemit,
Yixun Lan
Pinctrl is an essential driver for SpacemiT's SoC,
so let's enable it by default for this SoC.
The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
'make defconfig' to select kernel configuration options.
This result in a broken uart driver where fail at probe()
stage due to no pins found.
Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
Reported-by: Alex Elder <elder@kernel.org>
Signed-off-by: Yixun Lan <dlan@gentoo.org>
---
This should fix problem that CONFIG_PINCTRL_SPACEMIT_K1 is not enabled
when using make defconfig, thus fail to initilize uart driver which requst
pins during probe stage.
---
arch/riscv/Kconfig.socs | 1 +
drivers/pinctrl/spacemit/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 1916cf7ba450ec9958265de2ca41dc504d4d2f7c..17606940bb5239d0fdfc6b5aefb50eeb982d14aa 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -26,6 +26,7 @@ config ARCH_SOPHGO
config ARCH_SPACEMIT
bool "SpacemiT SoCs"
+ select PINCTRL
help
This enables support for SpacemiT SoC platform hardware.
diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
--- a/drivers/pinctrl/spacemit/Kconfig
+++ b/drivers/pinctrl/spacemit/Kconfig
@@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
tristate "SpacemiT K1 SoC Pinctrl driver"
depends on ARCH_SPACEMIT || COMPILE_TEST
depends on OF
+ default ARCH_SPACEMIT
select GENERIC_PINCTRL_GROUPS
select GENERIC_PINMUX_FUNCTIONS
select GENERIC_PINCONF
---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250207-k1-pinctrl-option-de5bdfd6b42e
Best regards,
--
Yixun Lan
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: spacemit: enable config option
2025-02-07 12:11 [PATCH] pinctrl: spacemit: enable config option Yixun Lan
@ 2025-02-07 16:49 ` Conor Dooley
2025-02-07 22:37 ` Yixun Lan
2025-02-07 18:00 ` Alex Elder
1 sibling, 1 reply; 6+ messages in thread
From: Conor Dooley @ 2025-02-07 16:49 UTC (permalink / raw)
To: Yixun Lan
Cc: Linus Walleij, Paul Walmsley, Palmer Dabbelt, Alex Elder,
linux-riscv, linux-kernel, linux-gpio, spacemit
[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]
On Fri, Feb 07, 2025 at 08:11:42PM +0800, Yixun Lan wrote:
> Pinctrl is an essential driver for SpacemiT's SoC,
> so let's enable it by default for this SoC.
>
> The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
> 'make defconfig' to select kernel configuration options.
> This result in a broken uart driver where fail at probe()
> stage due to no pins found.
>
> Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
> Reported-by: Alex Elder <elder@kernel.org>
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
> This should fix problem that CONFIG_PINCTRL_SPACEMIT_K1 is not enabled
> when using make defconfig, thus fail to initilize uart driver which requst
> pins during probe stage.
> ---
> arch/riscv/Kconfig.socs | 1 +
> drivers/pinctrl/spacemit/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 1916cf7ba450ec9958265de2ca41dc504d4d2f7c..17606940bb5239d0fdfc6b5aefb50eeb982d14aa 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -26,6 +26,7 @@ config ARCH_SOPHGO
>
> config ARCH_SPACEMIT
> bool "SpacemiT SoCs"
> + select PINCTRL
> help
> This enables support for SpacemiT SoC platform hardware.
>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
> --- a/drivers/pinctrl/spacemit/Kconfig
> +++ b/drivers/pinctrl/spacemit/Kconfig
> @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
> tristate "SpacemiT K1 SoC Pinctrl driver"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> + default ARCH_SPACEMIT
This is effectively just "default y", since ARCH_SPACEMIT is a
dependency.
> select GENERIC_PINCTRL_GROUPS
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250207-k1-pinctrl-option-de5bdfd6b42e
>
> Best regards,
> --
> Yixun Lan
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: spacemit: enable config option
2025-02-07 16:49 ` Conor Dooley
@ 2025-02-07 22:37 ` Yixun Lan
2025-02-11 16:03 ` Conor Dooley
0 siblings, 1 reply; 6+ messages in thread
From: Yixun Lan @ 2025-02-07 22:37 UTC (permalink / raw)
To: Conor Dooley
Cc: Linus Walleij, Paul Walmsley, Palmer Dabbelt, Alex Elder,
linux-riscv, linux-kernel, linux-gpio, spacemit
Hi Linus Walleij:
I think you won't mind if I take this patch through SpacemiT's SoC tree,
as it's fairly SpacemiT specific, right? anyway I'd appreciate if you
could give an ACK for this, thanks
Hi Conor:
On 16:49 Fri 07 Feb , Conor Dooley wrote:
> On Fri, Feb 07, 2025 at 08:11:42PM +0800, Yixun Lan wrote:
> > Pinctrl is an essential driver for SpacemiT's SoC,
> > so let's enable it by default for this SoC.
> >
> > The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
> > 'make defconfig' to select kernel configuration options.
> > This result in a broken uart driver where fail at probe()
> > stage due to no pins found.
> >
> > Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
> > Reported-by: Alex Elder <elder@kernel.org>
> > Signed-off-by: Yixun Lan <dlan@gentoo.org>
> > ---
> > This should fix problem that CONFIG_PINCTRL_SPACEMIT_K1 is not enabled
> > when using make defconfig, thus fail to initilize uart driver which requst
> > pins during probe stage.
> > ---
> > arch/riscv/Kconfig.socs | 1 +
> > drivers/pinctrl/spacemit/Kconfig | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > index 1916cf7ba450ec9958265de2ca41dc504d4d2f7c..17606940bb5239d0fdfc6b5aefb50eeb982d14aa 100644
> > --- a/arch/riscv/Kconfig.socs
> > +++ b/arch/riscv/Kconfig.socs
> > @@ -26,6 +26,7 @@ config ARCH_SOPHGO
> >
> > config ARCH_SPACEMIT
> > bool "SpacemiT SoCs"
> > + select PINCTRL
> > help
> > This enables support for SpacemiT SoC platform hardware.
> >
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
thanks Conor
> > diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> > index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
> > --- a/drivers/pinctrl/spacemit/Kconfig
> > +++ b/drivers/pinctrl/spacemit/Kconfig
> > @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
> > tristate "SpacemiT K1 SoC Pinctrl driver"
> > depends on ARCH_SPACEMIT || COMPILE_TEST
> > depends on OF
> > + default ARCH_SPACEMIT
>
> This is effectively just "default y", since ARCH_SPACEMIT is a
> dependency.
>
right, this is the plan, it make sense to bundle this config to ARCH_SPACEMIT
> > select GENERIC_PINCTRL_GROUPS
> > select GENERIC_PINMUX_FUNCTIONS
> > select GENERIC_PINCONF
> >
> > ---
> > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> > change-id: 20250207-k1-pinctrl-option-de5bdfd6b42e
> >
> > Best regards,
> > --
> > Yixun Lan
> >
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: spacemit: enable config option
2025-02-07 22:37 ` Yixun Lan
@ 2025-02-11 16:03 ` Conor Dooley
2025-02-12 7:25 ` Yixun Lan
0 siblings, 1 reply; 6+ messages in thread
From: Conor Dooley @ 2025-02-11 16:03 UTC (permalink / raw)
To: Yixun Lan
Cc: Linus Walleij, Paul Walmsley, Palmer Dabbelt, Alex Elder,
linux-riscv, linux-kernel, linux-gpio, spacemit
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Fri, Feb 07, 2025 at 10:37:05PM +0000, Yixun Lan wrote:
> On 16:49 Fri 07 Feb , Conor Dooley wrote:
> > On Fri, Feb 07, 2025 at 08:11:42PM +0800, Yixun Lan wrote:
> > > diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> > > index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
> > > --- a/drivers/pinctrl/spacemit/Kconfig
> > > +++ b/drivers/pinctrl/spacemit/Kconfig
> > > @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
> > > tristate "SpacemiT K1 SoC Pinctrl driver"
> > > depends on ARCH_SPACEMIT || COMPILE_TEST
> > > depends on OF
> > > + default ARCH_SPACEMIT
> >
> > This is effectively just "default y", since ARCH_SPACEMIT is a
> > dependency.
> >
> right, this is the plan, it make sense to bundle this config to ARCH_SPACEMIT
I don't think I was clear, I was trying to say that you should do
s/ARCH_SPACEMIT/y/ on this line.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: spacemit: enable config option
2025-02-11 16:03 ` Conor Dooley
@ 2025-02-12 7:25 ` Yixun Lan
0 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2025-02-12 7:25 UTC (permalink / raw)
To: Conor Dooley
Cc: Linus Walleij, Paul Walmsley, Palmer Dabbelt, Alex Elder,
linux-riscv, linux-kernel, linux-gpio, spacemit
On 16:03 Tue 11 Feb , Conor Dooley wrote:
> On Fri, Feb 07, 2025 at 10:37:05PM +0000, Yixun Lan wrote:
> > On 16:49 Fri 07 Feb , Conor Dooley wrote:
> > > On Fri, Feb 07, 2025 at 08:11:42PM +0800, Yixun Lan wrote:
> > > > diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> > > > index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
> > > > --- a/drivers/pinctrl/spacemit/Kconfig
> > > > +++ b/drivers/pinctrl/spacemit/Kconfig
> > > > @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
> > > > tristate "SpacemiT K1 SoC Pinctrl driver"
> > > > depends on ARCH_SPACEMIT || COMPILE_TEST
> > > > depends on OF
> > > > + default ARCH_SPACEMIT
> > >
> > > This is effectively just "default y", since ARCH_SPACEMIT is a
> > > dependency.
> > >
> > right, this is the plan, it make sense to bundle this config to ARCH_SPACEMIT
>
> I don't think I was clear, I was trying to say that you should do
> s/ARCH_SPACEMIT/y/ on this line.
make sense, since we already have "depends on ARCH_SPACEMIT" here,
it's kind of redundant to say ARCH_SPACEMIT again, will fix in v2
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: spacemit: enable config option
2025-02-07 12:11 [PATCH] pinctrl: spacemit: enable config option Yixun Lan
2025-02-07 16:49 ` Conor Dooley
@ 2025-02-07 18:00 ` Alex Elder
1 sibling, 0 replies; 6+ messages in thread
From: Alex Elder @ 2025-02-07 18:00 UTC (permalink / raw)
To: Yixun Lan, Linus Walleij, Paul Walmsley, Palmer Dabbelt
Cc: Alex Elder, linux-riscv, linux-kernel, linux-gpio, spacemit
On 2/7/25 6:11 AM, Yixun Lan wrote:
> Pinctrl is an essential driver for SpacemiT's SoC,
> so let's enable it by default for this SoC.
>
> The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using
> 'make defconfig' to select kernel configuration options.
> This result in a broken uart driver where fail at probe()
> stage due to no pins found.
>
> Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
> Reported-by: Alex Elder <elder@kernel.org>
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
> This should fix problem that CONFIG_PINCTRL_SPACEMIT_K1 is not enabled
> when using make defconfig, thus fail to initilize uart driver which requst
> pins during probe stage.
Thanks Yixun.
Tested-by: Alex Elder <elder@riscstar.com>
> ---
> arch/riscv/Kconfig.socs | 1 +
> drivers/pinctrl/spacemit/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 1916cf7ba450ec9958265de2ca41dc504d4d2f7c..17606940bb5239d0fdfc6b5aefb50eeb982d14aa 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -26,6 +26,7 @@ config ARCH_SOPHGO
>
> config ARCH_SPACEMIT
> bool "SpacemiT SoCs"
> + select PINCTRL
> help
> This enables support for SpacemiT SoC platform hardware.
>
> diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> index 168f8a5ffbb952cbeae3e3401c11149558e0a84b..aa3dea535def87ed75d86bc555b2b90643adbdea 100644
> --- a/drivers/pinctrl/spacemit/Kconfig
> +++ b/drivers/pinctrl/spacemit/Kconfig
> @@ -7,6 +7,7 @@ config PINCTRL_SPACEMIT_K1
> tristate "SpacemiT K1 SoC Pinctrl driver"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> + default ARCH_SPACEMIT
> select GENERIC_PINCTRL_GROUPS
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250207-k1-pinctrl-option-de5bdfd6b42e
>
> Best regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-12 7:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 12:11 [PATCH] pinctrl: spacemit: enable config option Yixun Lan
2025-02-07 16:49 ` Conor Dooley
2025-02-07 22:37 ` Yixun Lan
2025-02-11 16:03 ` Conor Dooley
2025-02-12 7:25 ` Yixun Lan
2025-02-07 18:00 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox