Re: [PATCH] pinctrl: amd: isp411: Add amdisp GPIO pinctrl

[kernel test robot <lkp@intel.com>]

Hi Pratap,

kernel test robot noticed the following build errors:

[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on linusw-pinctrl/for-next linus/master v6.14-rc4 next-20250228]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pratap-Nirujogi/pinctrl-amd-isp411-Add-amdisp-GPIO-pinctrl/20250301-011050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link:    https://lore.kernel.org/r/20250228165749.3476210-1-pratap.nirujogi%40amd.com
patch subject: [PATCH] pinctrl: amd: isp411: Add amdisp GPIO pinctrl
config: arc-randconfig-002-20250302 (https://download.01.org/0day-ci/archive/20250302/202503020508.tSquVmjP-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503020508.tSquVmjP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503020508.tSquVmjP-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/pinctrl/pinctrl-amdisp.c: In function 'amdisp_gpiochip_add':
>> drivers/pinctrl/pinctrl-amdisp.c:196:13: error: 'struct gpio_chip' has no member named 'of_node'; did you mean 'fwnode'?
     196 |         gc->of_node             = pdev->dev.of_node;
         |             ^~~~~~~
         |             fwnode
   In file included from drivers/pinctrl/pinctrl-amdisp.c:42:
   drivers/pinctrl/pinctrl-amd.h: At top level:
>> drivers/pinctrl/pinctrl-amd.h:1478:34: warning: 'pmx_functions' defined but not used [-Wunused-const-variable=]
    1478 | static const struct amd_function pmx_functions[] = {
         |                                  ^~~~~~~~~~~~~
>> drivers/pinctrl/pinctrl-amd.h:882:30: warning: 'kerncz_groups' defined but not used [-Wunused-const-variable=]
     882 | static const struct pingroup kerncz_groups[] = {
         |                              ^~~~~~~~~~~~~
>> drivers/pinctrl/pinctrl-amd.h:111:38: warning: 'kerncz_pins' defined but not used [-Wunused-const-variable=]
     111 | static const struct pinctrl_pin_desc kerncz_pins[] = {
         |                                      ^~~~~~~~~~~


vim +196 drivers/pinctrl/pinctrl-amdisp.c

   173	
   174	static int amdisp_gpiochip_add(struct platform_device *pdev,
   175				       struct amdisp_pinctrl *pctrl)
   176	{
   177		struct gpio_chip *gc = &pctrl->gc;
   178		struct pinctrl_gpio_range *grange = &pctrl->gpio_range;
   179		int ret;
   180	
   181		gc->label		= dev_name(pctrl->dev);
   182		gc->owner		= THIS_MODULE;
   183		gc->parent		= &pdev->dev;
   184		gc->names		= amdisp_range_pins_name;
   185		gc->request		= gpiochip_generic_request;
   186		gc->free		= gpiochip_generic_free;
   187		gc->get_direction	= amdisp_gpio_get_direction;
   188		gc->direction_input	= amdisp_gpio_direction_input;
   189		gc->direction_output	= amdisp_gpio_direction_output;
   190		gc->get			= amdisp_gpio_get;
   191		gc->set			= amdisp_gpio_set;
   192		gc->set_config		= amdisp_gpio_set_config;
   193		gc->base		= -1;
   194		gc->ngpio		= ARRAY_SIZE(amdisp_range_pins);
   195	#if defined(CONFIG_OF_GPIO)
 > 196		gc->of_node		= pdev->dev.of_node;
   197		gc->of_gpio_n_cells	= 2;
   198	#endif
   199	
   200		grange->id		= 0;
   201		grange->pin_base	= 0;
   202		grange->base		= 0;
   203		grange->pins		= amdisp_range_pins;
   204		grange->npins		= ARRAY_SIZE(amdisp_range_pins);
   205		grange->name		= gc->label;
   206		grange->gc		= gc;
   207	
   208		ret = devm_gpiochip_add_data(&pdev->dev, gc, pctrl);
   209		if (ret)
   210			return ret;
   211	
   212		pinctrl_add_gpio_range(pctrl->pctrl, grange);
   213	
   214		dev_info(&pdev->dev, "register amdisp gpio controller\n");
   215		return 0;
   216	}
   217	#endif
   218	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki