* [PATCH] pinctrl: mediatek: Fix new design debounce issue
@ 2025-04-22 7:52 Hao Chang
2025-04-23 8:45 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Hao Chang @ 2025-04-22 7:52 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Wenbin Mei, Axe Yang, Qingliang Li, Hanks Chen, Chunhui Li,
linux-mediatek, linux-gpio, linux-kernel, linux-arm-kernel,
Hao Chang
Calculate the true offset of eint according to index.
Fixes: 3ef9f710efcb ("pinctrl: mediatek: Add EINT support for multiple addresses")
Signed-off-by: Hao Chang <ot_chhao.chang@mediatek.com>
Signed-off-by: Qingliang Li <qingliang.li@mediatek.com>
---
drivers/pinctrl/mediatek/mtk-eint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/mtk-eint.c b/drivers/pinctrl/mediatek/mtk-eint.c
index 557dec75fa03..be12ef1fd6b0 100644
--- a/drivers/pinctrl/mediatek/mtk-eint.c
+++ b/drivers/pinctrl/mediatek/mtk-eint.c
@@ -449,7 +449,7 @@ int mtk_eint_set_debounce(struct mtk_eint *eint, unsigned long eint_num,
return -EOPNOTSUPP;
virq = irq_find_mapping(eint->domain, eint_num);
- eint_offset = (eint_num % 4) * 8;
+ eint_offset = (idx % 4) * 8;
d = irq_get_irq_data(virq);
set_offset = (idx / 4) * 4 + eint->regs->dbnc_set;
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: mediatek: Fix new design debounce issue
2025-04-22 7:52 [PATCH] pinctrl: mediatek: Fix new design debounce issue Hao Chang
@ 2025-04-23 8:45 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-04-23 8:45 UTC (permalink / raw)
To: Hao Chang
Cc: Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
Wenbin Mei, Axe Yang, Qingliang Li, Hanks Chen, Chunhui Li,
linux-mediatek, linux-gpio, linux-kernel, linux-arm-kernel
On Tue, Apr 22, 2025 at 9:52 AM Hao Chang <ot_chhao.chang@mediatek.com> wrote:
> Calculate the true offset of eint according to index.
>
> Fixes: 3ef9f710efcb ("pinctrl: mediatek: Add EINT support for multiple addresses")
> Signed-off-by: Hao Chang <ot_chhao.chang@mediatek.com>
> Signed-off-by: Qingliang Li <qingliang.li@mediatek.com>
Looks like a serious issue, patch applied to fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-23 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 7:52 [PATCH] pinctrl: mediatek: Fix new design debounce issue Hao Chang
2025-04-23 8:45 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox