[PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505210606.PudPm5pC-lkp@intel.com/
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

Hi Bartosz,

 I follow same approach as you did.
 My last build using multi defconfig was not enough.
 I tried build all arch/arm/configs/*, no errors with this patch applied.

Thanks,
Peng

 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a559d5bb8249..c3465fd82b08 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -253,6 +253,7 @@ config GPIO_DAVINCI
 	tristate "TI Davinci/Keystone GPIO support"
 	default y if ARCH_DAVINCI
 	depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
+	select GPIOLIB_IRQCHIP
 	help
 	  Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
 
-- 
2.37.1

[PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505210606.PudPm5pC-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Another one signalled by the build bot. Peng: if you could go through
the other patches you sent and verify their dependencies are satisfied,
that would be awesome.

 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index bbc71cdde9ed6..5bc31b56b5157 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -253,6 +253,7 @@ config GPIO_DAVINCI
 	tristate "TI Davinci/Keystone GPIO support"
 	default y if ARCH_DAVINCI
 	depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
+	select GPIOLIB_IRQCHIP
 	help
 	  Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
 
-- 
2.48.1

RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Peng Fan]

> Subject: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
> 
> Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore.kernel.org%2Foe-kbuild-all%2F202505210606.PudPm5pC-
> lkp%40intel.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7Ca0
> c5af787d854064539608dd983883ab%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C638834090666472921%7CUnknown%7CTW
> FpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAi
> OiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&
> sdata=DMwJeyC%2Bu4xmb1Ijuf6erLE3EVgprzEW%2FR4Gjo55zOs%3D
> &reserved=0
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Peng Fan <peng.fan@nxp.com>

> ---
> Another one signalled by the build bot. Peng: if you could go through
> the other patches you sent and verify their dependencies are satisfied,
> that would be awesome.

I tried all configs under arch/arm/configs/, no error with this patch applied.
I will give a check on other archs.

Thanks,
Peng

> 
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> bbc71cdde9ed6..5bc31b56b5157 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -253,6 +253,7 @@ config GPIO_DAVINCI
>  	tristate "TI Davinci/Keystone GPIO support"
>  	default y if ARCH_DAVINCI
>  	depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
> ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
> +	select GPIOLIB_IRQCHIP
>  	help
>  	  Say yes here to enable GPIO support for TI Davinci/Keystone
> SoCs.
> 
> --
> 2.48.1

RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Peng Fan]

> Subject: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
> 
> Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-
> all/202505210606.PudPm5pC-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Drop this patch. 

Bartosz had a fix.

Thanks,
Peng.

Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Bartosz Golaszewski]

On Wed, May 21, 2025 at 9:22 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
>
> Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505210606.PudPm5pC-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> Hi Bartosz,
>
>  I follow same approach as you did.
>  My last build using multi defconfig was not enough.
>  I tried build all arch/arm/configs/*, no errors with this patch applied.
>
> Thanks,
> Peng
>
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a559d5bb8249..c3465fd82b08 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -253,6 +253,7 @@ config GPIO_DAVINCI
>         tristate "TI Davinci/Keystone GPIO support"
>         default y if ARCH_DAVINCI
>         depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
> +       select GPIOLIB_IRQCHIP
>         help
>           Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
>
> --
> 2.37.1
>

Ah, you beat me to it by 2 minutes.

Bart

RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Peng Fan]

> Subject: Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> On Wed, May 21, 2025 at 9:22 AM Peng Fan (OSS)
> <peng.fan@oss.nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> > are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig
> select.
> >
> > Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore
> > .kernel.org%2Foe-kbuild-all%2F202505210606.PudPm5pC-
> lkp%40intel.com%2F
> >
> &data=05%7C02%7Cpeng.fan%40nxp.com%7C643974af18114f5850b
> 208dd9839437e%
> >
> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6388340938
> 85187545%7CUnkn
> >
> own%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMD
> AwMCIsIlAiOiJX
> >
> aW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
> a=GCJh4QciYp
> > JMPAQQD63sh0jdUbkNcxQ5bbfxnLwDLfs%3D&reserved=0
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > Hi Bartosz,
> >
> >  I follow same approach as you did.
> >  My last build using multi defconfig was not enough.
> >  I tried build all arch/arm/configs/*, no errors with this patch applied.
> >
> > Thanks,
> > Peng
> >
> >  drivers/gpio/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> > a559d5bb8249..c3465fd82b08 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -253,6 +253,7 @@ config GPIO_DAVINCI
> >         tristate "TI Davinci/Keystone GPIO support"
> >         default y if ARCH_DAVINCI
> >         depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
> ARCH_KEYSTONE
> > || ARCH_K3)) || COMPILE_TEST
> > +       select GPIOLIB_IRQCHIP
> >         help
> >           Say yes here to enable GPIO support for TI Davinci/Keystone
> SoCs.
> >
> > --
> > 2.37.1
> >
> 
> Ah, you beat me to it by 2 minutes.

No problem, just drop my patch. Pick yours, since I copied
you idea on the fix.

Thanks,
Peng

> 
> Bart

RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Peng Fan]

Hi Bartosz,

> Subject: RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> > Subject: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> >
> 
> > ---
> > Another one signalled by the build bot. Peng: if you could go through
> > the other patches you sent and verify their dependencies are
> > satisfied, that would be awesome.
> 
> I tried all configs under arch/arm/configs/, no error with this patch
> applied.
> I will give a check on other archs.

For other Kconfig entries, would you help add a patch to 
select GPIOLIB_IRQCHIP for them all to avoid potential issue?

GPIO_TIMBERDALE: no configs select this entry
GPIO_BCM_KONA: multi_v7_defconfig has GPIOLIB_IRQCHIP in .config
GPIO_LPC18XX: lpc18xx_defconfig has GPIOLIB_IRQCHIP in .config
GPIO_XGENE: arm64 defconfig has GPIOLIB_IRQCHIP in .config
GPIO_GRGPIO: no configs select this entry

Thanks,
Peng

> 
> Thanks,
> Peng
> 
> >
> >  drivers/gpio/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> > bbc71cdde9ed6..5bc31b56b5157 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -253,6 +253,7 @@ config GPIO_DAVINCI
> >  	tristate "TI Davinci/Keystone GPIO support"
> >  	default y if ARCH_DAVINCI
> >  	depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
> ARCH_KEYSTONE ||
> > ARCH_K3)) || COMPILE_TEST
> > +	select GPIOLIB_IRQCHIP
> >  	help
> >  	  Say yes here to enable GPIO support for TI Davinci/Keystone
> SoCs.
> >
> > --
> > 2.48.1

Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Bartosz Golaszewski]

On Wed, May 21, 2025 at 9:50 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Bartosz,
>
> > Subject: RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> >
> > > Subject: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> > >
> >
> > > ---
> > > Another one signalled by the build bot. Peng: if you could go through
> > > the other patches you sent and verify their dependencies are
> > > satisfied, that would be awesome.
> >
> > I tried all configs under arch/arm/configs/, no error with this patch
> > applied.
> > I will give a check on other archs.
>
> For other Kconfig entries, would you help add a patch to
> select GPIOLIB_IRQCHIP for them all to avoid potential issue?
>
> GPIO_TIMBERDALE: no configs select this entry
> GPIO_BCM_KONA: multi_v7_defconfig has GPIOLIB_IRQCHIP in .config
> GPIO_LPC18XX: lpc18xx_defconfig has GPIOLIB_IRQCHIP in .config
> GPIO_XGENE: arm64 defconfig has GPIOLIB_IRQCHIP in .config
> GPIO_GRGPIO: no configs select this entry
>

I think all of them need to select GPIOLIB_IRQCHIP. Defconfig is not
enough as a randconfig can still break in this case.

Bart

Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 21 May 2025 15:20:48 +0800, Peng Fan (OSS) wrote:
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
> 
> 

Applied, thanks!

[1/1] gpio: davinci: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/4347566404a0f01e9dc654a0b806a582ee63f68b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

[Peng Fan]

> Subject: Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> On Wed, May 21, 2025 at 9:50 AM Peng Fan <peng.fan@nxp.com>
> wrote:
> >
> > Hi Bartosz,
> >
> > > Subject: RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> > >
> > > > Subject: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> > > >
> > >
> > > > ---
> > > > Another one signalled by the build bot. Peng: if you could go
> > > > through the other patches you sent and verify their dependencies
> > > > are satisfied, that would be awesome.
> > >
> > > I tried all configs under arch/arm/configs/, no error with this
> > > patch applied.
> > > I will give a check on other archs.
> >
> > For other Kconfig entries, would you help add a patch to select
> > GPIOLIB_IRQCHIP for them all to avoid potential issue?
> >
> > GPIO_TIMBERDALE: no configs select this entry
> > GPIO_BCM_KONA: multi_v7_defconfig has GPIOLIB_IRQCHIP
> in .config
> > GPIO_LPC18XX: lpc18xx_defconfig has GPIOLIB_IRQCHIP in .config
> > GPIO_XGENE: arm64 defconfig has GPIOLIB_IRQCHIP in .config
> > GPIO_GRGPIO: no configs select this entry
> >
> 
> I think all of them need to select GPIOLIB_IRQCHIP. Defconfig is not
> enough as a randconfig can still break in this case.

ok. I will prepare a patchset soon for this.

Thanks,
Peng

> 
> Bart