[PATCH] pinctrl: fix kismet issues with GENERIC_PINCTRL

[PATCH] pinctrl: fix kismet issues with GENERIC_PINCTRL

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

lkp reported that GENERIC_PINCTRL can be select when its dependencies
are not. Swap the "depends on" out for "select", as is used in other
parts of the pinctrl core that are expected to be selected by drivers.

Fixes: 43722575e5cd ("pinctrl: add generic functions + pins mapper")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601271725.gqlQ8Jl7-lkp@intel.com/
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 drivers/pinctrl/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 6cc5e214f4f3..afecd9407f53 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -27,9 +27,9 @@ config GENERIC_PINCONF
 
 config GENERIC_PINCTRL
 	bool
-	depends on GENERIC_PINCONF
-	depends on GENERIC_PINCTRL_GROUPS
-	depends on GENERIC_PINMUX_FUNCTIONS
+	select GENERIC_PINCONF
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
 
 config DEBUG_PINCTRL
 	bool "Debug PINCTRL calls"
-- 
2.51.0

Re: [PATCH] pinctrl: fix kismet issues with GENERIC_PINCTRL

[Linus Walleij]

On Sat, Jan 31, 2026 at 12:55 AM Conor Dooley <conor@kernel.org> wrote:

> From: Conor Dooley <conor.dooley@microchip.com>
>
> lkp reported that GENERIC_PINCTRL can be select when its dependencies
> are not. Swap the "depends on" out for "select", as is used in other
> parts of the pinctrl core that are expected to be selected by drivers.
>
> Fixes: 43722575e5cd ("pinctrl: add generic functions + pins mapper")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601271725.gqlQ8Jl7-lkp@intel.com/
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Patch applied!

Yours,
Linus Walleij