Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: linusw@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, afaerber@suse.com,
	bartosz.golaszewski@oss.qualcomm.com, james.tai@realtek.com,
	cy.huang@realtek.com, stanley_chang@realtek.com,
	tychang@realtek.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-realtek-soc@lists.infradead.org
Subject: Re: [PATCH v3 1/7] dt-bindings: pincfg-node: Add input-voltage-microvolt property
Date: Thu, 12 Mar 2026 17:44:46 +0000	[thread overview]
Message-ID: <20260312-sizably-gleaming-07c514a1fb70@spud> (raw)
In-Reply-To: <20260312-decathlon-unheard-33543f7c9f38@spud>

[-- Attachment #1: Type: text/plain, Size: 2493 bytes --]

On Thu, Mar 12, 2026 at 05:42:31PM +0000, Conor Dooley wrote:
> On Thu, Mar 12, 2026 at 07:30:34PM +0800, Yu-Chun Lin wrote:
> > From: Tzuyi Chang <tychang@realtek.com>
> > 
> > Add a generic pin configuration property "input-voltage-microvolt" to
> > support hardware designs where the input logic threshold is decoupled
> > from the power supply voltage.
> > 
> > This property allows the pinctrl driver to configure the correct internal
> > reference voltage for pins that need to accept input signals at a different
> > voltage level than their power supply. For example, a pin powered by 3.3V
> > may need to accept 1.8V logic signals.
> > 
> > This defines the reference for VIH (Input High Voltage) and VIL (Input Low
> > Voltage) thresholds, enabling proper signal detection across different
> > voltage domains.
> > 
> > Signed-off-by: Tzuyi Chang <tychang@realtek.com>
> > Co-developed-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> > Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> > ---
> > Changes in v3:
> > - Rebased onto the devel branch of the pinctrl tree.
> > - Improved commit message and description.
> > ---
> >  Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > index fe936ab09104..fd49a0d53bf0 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > @@ -162,6 +162,11 @@ properties:
> >        this affects the expected delay in ps before latching a value to
> >        an output pin.
> >  
> > +  input-voltage-microvolt:
> > +    description: Specifies the input voltage level of the pin in microvolts.
> > +      This defines the reference for  VIH (Input High Voltage) and VIL
> > +      (Input Low Voltage) thresholds for proper signal detection.
> 
> Should this be added here:
>   - if:
>       required:
>         - input-disable
>     then:
>       properties:
>         input-enable: false
> 
> and made mutually exclusive with input-disable?

Also looking at v1, should this be something like
"input-threshold-voltage-microvolt"? "input-voltage-microvolt" doesn't
seem specific enough to the described use case.

> 
> > +
> >  allOf:
> >    - if:
> >        required:
> > -- 
> > 2.34.1
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-03-12 17:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 11:30 [PATCH v3 0/7] pinctrl: realtek: Core improvements and RTD1625 support Yu-Chun Lin
2026-03-12 11:30 ` [PATCH v3 1/7] dt-bindings: pincfg-node: Add input-voltage-microvolt property Yu-Chun Lin
2026-03-12 17:42   ` Conor Dooley
2026-03-12 17:44     ` Conor Dooley [this message]
2026-03-16  9:02       ` Yu-Chun Lin [林祐君]
2026-03-12 11:30 ` [PATCH v3 2/7] pinctrl: pinconf-generic: Add properties 'input-voltage-microvolt' Yu-Chun Lin
2026-03-16 13:48   ` Linus Walleij
2026-03-12 11:30 ` [PATCH v3 3/7] dt-bindings: pinctrl: realtek: Improve 'realtek,duty-cycle' description Yu-Chun Lin
2026-03-12 17:42   ` Conor Dooley
2026-03-16 13:47   ` Linus Walleij
2026-03-12 11:30 ` [PATCH v3 4/7] dt-bindings: pinctrl: realtek: Add RTD1625 pinctrl binding Yu-Chun Lin
2026-03-12 17:46   ` Conor Dooley
2026-03-16 13:48   ` Linus Walleij
2026-03-12 11:30 ` [PATCH v3 5/7] pinctrl: realtek: add support for slew rate, input voltage and high VIL Yu-Chun Lin
2026-03-16 13:49   ` Linus Walleij
2026-03-12 11:30 ` [PATCH v3 2/3] pinctrl: realtek: add rtd1625 pinctrl driver Yu-Chun Lin
2026-03-12 11:30 ` [PATCH v3 3/3] arm64: dts: realtek: Add pinctrl support for RTD1625 Yu-Chun Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312-sizably-gleaming-07c514a1fb70@spud \
    --to=conor@kernel.org \
    --cc=afaerber@suse.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=cy.huang@realtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eleanor.lin@realtek.com \
    --cc=james.tai@realtek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stanley_chang@realtek.com \
    --cc=tychang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox