* [PATCH v2] pinctrl: abx500: Fix type of 'argument' variable
@ 2026-03-20 15:15 Yu-Chun Lin
2026-03-23 13:26 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Yu-Chun Lin @ 2026-03-20 15:15 UTC (permalink / raw)
To: linusw, laurent.pinchart, matt.porter, syin, csd
Cc: linux-arm-kernel, linux-gpio, linux-kernel, Yu-Chun Lin
The argument variable is assigned the return value of
pinconf_to_config_argument(), which returns a u32. Change its type from
enum pin_config_param to unsigned int to correctly store the configuration
argument.
Fixes: 03b054e9696c ("pinctrl: Pass all configs to driver on pin_config_set()")
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
---
Changes in v2:
- Rebased on the latest mainline to fix the recipient list.
- Updated the variable type to match the commit message.
---
drivers/pinctrl/nomadik/pinctrl-abx500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c
index fc7ebeda8440..858fbaebcf8e 100644
--- a/drivers/pinctrl/nomadik/pinctrl-abx500.c
+++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c
@@ -852,7 +852,7 @@ static int abx500_pin_config_set(struct pinctrl_dev *pctldev,
int ret = -EINVAL;
int i;
enum pin_config_param param;
- enum pin_config_param argument;
+ unsigned int argument;
for (i = 0; i < num_configs; i++) {
param = pinconf_to_config_param(configs[i]);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] pinctrl: abx500: Fix type of 'argument' variable
2026-03-20 15:15 [PATCH v2] pinctrl: abx500: Fix type of 'argument' variable Yu-Chun Lin
@ 2026-03-23 13:26 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2026-03-23 13:26 UTC (permalink / raw)
To: Yu-Chun Lin
Cc: laurent.pinchart, matt.porter, syin, csd, linux-arm-kernel,
linux-gpio, linux-kernel
On Fri, Mar 20, 2026 at 4:15 PM Yu-Chun Lin <eleanor15x@gmail.com> wrote:
> The argument variable is assigned the return value of
> pinconf_to_config_argument(), which returns a u32. Change its type from
> enum pin_config_param to unsigned int to correctly store the configuration
> argument.
>
> Fixes: 03b054e9696c ("pinctrl: Pass all configs to driver on pin_config_set()")
> Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Patch applied as nonurgent fix, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-23 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-20 15:15 [PATCH v2] pinctrl: abx500: Fix type of 'argument' variable Yu-Chun Lin
2026-03-23 13:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox