Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Marco Scardovi <mscardovi95@gmail.com>
To: andriy.shevchenko@intel.com
Cc: linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
	mika.westerberg@intel.com, Marco Scardovi <mscardovi95@gmail.com>
Subject: [PATCH v4 3/6] gpio: acpi: ignore out-of-range pins in acpi_gpiochip_alloc_event()
Date: Fri,  8 May 2026 08:17:26 +0200	[thread overview]
Message-ID: <20260508061729.9530-4-mscardovi95@gmail.com> (raw)
In-Reply-To: <20260508061729.9530-1-mscardovi95@gmail.com>

Add a check to verify that the pin index retrieved from ACPI is within
the valid range for the GPIO chip (pin < chip->ngpio). If the pin is
out of range, an error is logged and the function returns early to
avoid invalid memory access.

Signed-off-by: Marco Scardovi <mscardovi95@gmail.com>
---
 drivers/gpio/gpiolib-acpi-core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c
index eb8a40cfb7a9..e53d68578024 100644
--- a/drivers/gpio/gpiolib-acpi-core.c
+++ b/drivers/gpio/gpiolib-acpi-core.c
@@ -370,6 +370,11 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares,
 	handle = ACPI_HANDLE(chip->parent);
 	pin = agpio->pin_table[0];
 
+	if (pin >= chip->ngpio) {
+		dev_err(chip->parent, "Failed to request GPIO for pin 0x%04X, out of range\n", pin);
+		return AE_OK;
+	}
+
 	if (pin <= 255) {
 		char ev_name[8];
 		sprintf(ev_name, "_%c%02X",
-- 
2.54.0


  parent reply	other threads:[~2026-05-08  6:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260506123421.1077421-1-mscardovi95@gmail.com>
2026-05-07 15:56 ` [PATCH v3 0/6] gpio: acpi: modernize resource management using cleanup.h Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 1/6] ACPI: Move DEFINE_FREE(acpi_free) to global header Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 2/6] gpiolib: Move DEFINE_FREE(free_gpio_desc) to driver header Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 3/6] gpio: acpi: ignore out-of-range pins in acpi_gpiochip_alloc_event() Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 4/6] gpio: acpi: use guard(mutex) for conn_lock Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 5/6] gpio: acpi: use cleanup.h for automated resource deallocation Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 6/6] gpio: acpi: sort header inclusion alphabetically Marco Scardovi
2026-05-07 19:19   ` [PATCH v3 0/6] gpio: acpi: modernize resource management using cleanup.h Andy Shevchenko
2026-05-08  6:17     ` [PATCH v4 " Marco Scardovi
2026-05-08  6:17       ` [PATCH v4 1/6] ACPI: Move DEFINE_FREE(acpi_free) to global header Marco Scardovi
2026-05-08 18:40         ` Rafael J. Wysocki
2026-05-08  6:17       ` [PATCH v4 2/6] gpiolib: Move DEFINE_FREE(free_gpio_desc) to driver header Marco Scardovi
2026-05-08  6:17       ` Marco Scardovi [this message]
2026-05-08  6:17       ` [PATCH v4 4/6] gpio: acpi: use guard(mutex) for conn_lock Marco Scardovi
2026-05-08  6:17       ` [PATCH v4 5/6] gpio: acpi: use cleanup.h for automated resource deallocation Marco Scardovi
2026-05-08 18:44         ` Rafael J. Wysocki
2026-05-08  6:17       ` [PATCH v4 6/6] gpio: acpi: sort header inclusion alphabetically Marco Scardovi
2026-05-08  7:21       ` [PATCH v4 0/6] gpio: acpi: modernize resource management using cleanup.h Andy Shevchenko
2026-05-08  7:22         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508061729.9530-4-mscardovi95@gmail.com \
    --to=mscardovi95@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mika.westerberg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox