Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Marco Scardovi <mscardovi95@gmail.com>
To: andriy.shevchenko@intel.com
Cc: linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
	mika.westerberg@intel.com, Marco Scardovi <mscardovi95@gmail.com>
Subject: [PATCH v4 4/6] gpio: acpi: use guard(mutex) for conn_lock
Date: Fri,  8 May 2026 08:17:27 +0200	[thread overview]
Message-ID: <20260508061729.9530-5-mscardovi95@gmail.com> (raw)
In-Reply-To: <20260508061729.9530-1-mscardovi95@gmail.com>

Replace manual mutex_lock() and mutex_unlock() calls in
acpi_gpio_adr_space_handler() with the guard(mutex) helper. This
ensures the conn_lock is automatically released when exiting the
scope, preventing potential deadlocks and simplifying the logic.

Signed-off-by: Marco Scardovi <mscardovi95@gmail.com>
---
 drivers/gpio/gpiolib-acpi-core.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c
index e53d68578024..33d6c3b6cdf0 100644
--- a/drivers/gpio/gpiolib-acpi-core.c
+++ b/drivers/gpio/gpiolib-acpi-core.c
@@ -1123,7 +1123,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
 		u16 word, shift;
 		bool found;
 
-		mutex_lock(&achip->conn_lock);
+		guard(mutex)(&achip->conn_lock);
 
 		found = false;
 		list_for_each_entry(conn, &achip->conns, node) {
@@ -1155,17 +1155,15 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
 		if (!found) {
 			desc = acpi_request_own_gpiod(chip, agpio, i, "ACPI:OpRegion");
 			if (IS_ERR(desc)) {
-				mutex_unlock(&achip->conn_lock);
 				status = AE_ERROR;
-				goto out;
+				break;
 			}
 
 			conn = kzalloc_obj(*conn);
 			if (!conn) {
 				gpiochip_free_own_desc(desc);
-				mutex_unlock(&achip->conn_lock);
 				status = AE_NO_MEMORY;
-				goto out;
+				break;
 			}
 
 			conn->pin = pin;
@@ -1173,8 +1171,6 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
 			list_add_tail(&conn->node, &achip->conns);
 		}
 
-		mutex_unlock(&achip->conn_lock);
-
 		/*
 		 * For the cases when OperationRegion() consists of more than
 		 * 64 bits calculate the word and bit shift to use that one to
-- 
2.54.0


  parent reply	other threads:[~2026-05-08  6:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260506123421.1077421-1-mscardovi95@gmail.com>
2026-05-07 15:56 ` [PATCH v3 0/6] gpio: acpi: modernize resource management using cleanup.h Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 1/6] ACPI: Move DEFINE_FREE(acpi_free) to global header Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 2/6] gpiolib: Move DEFINE_FREE(free_gpio_desc) to driver header Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 3/6] gpio: acpi: ignore out-of-range pins in acpi_gpiochip_alloc_event() Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 4/6] gpio: acpi: use guard(mutex) for conn_lock Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 5/6] gpio: acpi: use cleanup.h for automated resource deallocation Marco Scardovi
2026-05-07 15:56   ` [PATCH v3 6/6] gpio: acpi: sort header inclusion alphabetically Marco Scardovi
2026-05-07 19:19   ` [PATCH v3 0/6] gpio: acpi: modernize resource management using cleanup.h Andy Shevchenko
2026-05-08  6:17     ` [PATCH v4 " Marco Scardovi
2026-05-08  6:17       ` [PATCH v4 1/6] ACPI: Move DEFINE_FREE(acpi_free) to global header Marco Scardovi
2026-05-08 18:40         ` Rafael J. Wysocki
2026-05-08  6:17       ` [PATCH v4 2/6] gpiolib: Move DEFINE_FREE(free_gpio_desc) to driver header Marco Scardovi
2026-05-08  6:17       ` [PATCH v4 3/6] gpio: acpi: ignore out-of-range pins in acpi_gpiochip_alloc_event() Marco Scardovi
2026-05-08  6:17       ` Marco Scardovi [this message]
2026-05-08  6:17       ` [PATCH v4 5/6] gpio: acpi: use cleanup.h for automated resource deallocation Marco Scardovi
2026-05-08 18:44         ` Rafael J. Wysocki
2026-05-08  6:17       ` [PATCH v4 6/6] gpio: acpi: sort header inclusion alphabetically Marco Scardovi
2026-05-08  7:21       ` [PATCH v4 0/6] gpio: acpi: modernize resource management using cleanup.h Andy Shevchenko
2026-05-08  7:22         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508061729.9530-5-mscardovi95@gmail.com \
    --to=mscardovi95@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mika.westerberg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox