[PATCH] gpio: nomadik: remove dead DB8540 code from <gpio/gpio-nomadik.h>

[PATCH] gpio: nomadik: remove dead DB8540 code from <gpio/gpio-nomadik.h>

[Ethan Nelson-Moore]

DB8540 support was removed in commit b6d09f780761 ("pinctrl: nomadik:
Drop U8540/9540 support"), but a couple small pieces of related code
remained in <gpio/gpio-nomadik.h>. Remove them.

Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
 include/linux/gpio/gpio-nomadik.h | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/include/linux/gpio/gpio-nomadik.h b/include/linux/gpio/gpio-nomadik.h
index 8061b9826361..44c47645649c 100644
--- a/include/linux/gpio/gpio-nomadik.h
+++ b/include/linux/gpio/gpio-nomadik.h
@@ -32,9 +32,6 @@ struct fwnode_handle;
 #define NMK_GPIO_RWIMSC	0x50
 #define NMK_GPIO_FWIMSC	0x54
 #define NMK_GPIO_WKS	0x58
-/* These appear in DB8540 and later ASICs */
-#define NMK_GPIO_EDGELEVEL 0x5C
-#define NMK_GPIO_LEVEL	0x60
 
 /* Pull up/down values */
 enum nmk_gpio_pull {
@@ -236,19 +233,6 @@ nmk_pinctrl_db8500_init(const struct nmk_pinctrl_soc_data **soc)
 
 #endif
 
-#ifdef CONFIG_PINCTRL_DB8540
-
-void nmk_pinctrl_db8540_init(const struct nmk_pinctrl_soc_data **soc);
-
-#else
-
-static inline void
-nmk_pinctrl_db8540_init(const struct nmk_pinctrl_soc_data **soc)
-{
-}
-
-#endif
-
 struct platform_device;
 
 #ifdef CONFIG_DEBUG_FS
-- 
2.43.0

Re: [PATCH] gpio: nomadik: remove dead DB8540 code from <gpio/gpio-nomadik.h>

[Linus Walleij]

On Wed, Jun 10, 2026 at 10:50 PM Ethan Nelson-Moore
<enelsonmoore@gmail.com> wrote:

> DB8540 support was removed in commit b6d09f780761 ("pinctrl: nomadik:
> Drop U8540/9540 support"), but a couple small pieces of related code
> remained in <gpio/gpio-nomadik.h>. Remove them.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>

Good catch!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH] gpio: nomadik: remove dead DB8540 code from <gpio/gpio-nomadik.h>

[Ethan Nelson-Moore]

Hi, Linus,

On Wed, Jun 10, 2026 at 2:02 PM Linus Walleij <linusw@kernel.org> wrote:
> Good catch!

Thanks! It looks like there might be a lot more related dead code; try running:
grep -Ri '[AD]B[89]540'

Ethan

Re: [PATCH] gpio: nomadik: remove dead DB8540 code from <gpio/gpio-nomadik.h>

[Bartosz Golaszewski]

On Wed, 10 Jun 2026 13:50:07 -0700, Ethan Nelson-Moore wrote:
> DB8540 support was removed in commit b6d09f780761 ("pinctrl: nomadik:
> Drop U8540/9540 support"), but a couple small pieces of related code
> remained in <gpio/gpio-nomadik.h>. Remove them.
> 
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
> 
> [...]

Applied, thanks!

[1/1] gpio: nomadik: remove dead DB8540 code from <gpio/gpio-nomadik.h>
      https://git.kernel.org/brgl/c/f953585dafd71ecb0897f9def9c0a3702afc1bf8

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>