Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Junjie Cao <junjie.cao@intel.com>
To: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Andy Shevchenko <andy@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH] gpio: pch: use raw_spinlock_t for the register lock
Date: Mon, 27 Jul 2026 23:18:14 +0800	[thread overview]
Message-ID: <20260727151902.214691-1-junjie.cao@intel.com> (raw)
In-Reply-To: <CAD++jL=EJyWpqjwCdfosdanjS9GUAwMEJjHFrcvMyBV3iKHZZw@mail.gmail.com>

Hi Linus,

Thanks for the review!

> Really? Why to stable? Is this a regression of something that
> used to work before? Using RT is fringe IMO.

No -- it is indeed not a regression: the lock has been a plain
spinlock_t since IRQ support landed in 2011, so it never worked on
PREEMPT_RT rather than regressing. I Cc'd stable because current LTS
kernels with PREEMPT_RT hit this sleeping-in-atomic BUG today, like
the two fixes I referenced (286533cb14a3, 90f0109019e6, both Cc'd
stable); Bartosz has since applied it with the tag kept, so I'm happy
to defer to whatever you and he prefer.

Many thanks,
Junjie

  reply	other threads:[~2026-07-27 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  1:41 [PATCH] gpio: pch: use raw_spinlock_t for the register lock Junjie Cao
2026-07-25  9:50 ` Linus Walleij
2026-07-27 15:18   ` Junjie Cao [this message]
2026-07-29  7:22     ` Linus Walleij
2026-07-27 13:08 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727151902.214691-1-junjie.cao@intel.com \
    --to=junjie.cao@intel.com \
    --cc=andy@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=bigeasy@linutronix.de \
    --cc=brgl@kernel.org \
    --cc=clrkwllms@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox