Linux GPIO subsystem development
 help / color / mirror / Atom feed
* [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM
@ 2026-08-08 15:55 Yao Qi
  2026-08-08 19:42 ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Yao Qi @ 2026-08-08 15:55 UTC (permalink / raw)
  To: westeri, andriy.shevchenko, linusw, brgl
  Cc: linux-gpio, linux-acpi, linux-kernel, Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
(Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through
GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
unwanted wakeups. This has been runtime-tested and verified using the
`gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.

Signed-off-by: Yao Qi <xnorigc@gmail.com>
---
 drivers/gpio/gpiolib-acpi-quirks.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index a0116f004..8d7d18b62 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -392,6 +392,19 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "VEN_0488:00@355",
 		},
 	},
+	{
+		/*
+		 * Spurious wakeups from s2idle when suspended with an
+		 * external HDMI display connected.
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401GM"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "AMDI0030:00@24",
+		},
+	},
 	{} /* Terminating entry */
 };
 
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM
  2026-08-08 15:55 [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM Yao Qi
@ 2026-08-08 19:42 ` Andy Shevchenko
  2026-08-09 22:17   ` Linus Walleij
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2026-08-08 19:42 UTC (permalink / raw)
  To: Yao Qi; +Cc: westeri, linusw, brgl, linux-gpio, linux-acpi, linux-kernel

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:
> The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> (Modern Standby) when suspended with an external HDMI display connected.
> 
> This issue is caused by spurious ACPI event signaling routed through
> GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> 
> Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> unwanted wakeups. This has been runtime-tested and verified using the
> `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.

If AMD people will be quick enough to tag this, I will include in my PR to
Linus W. on next week.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM
  2026-08-08 19:42 ` Andy Shevchenko
@ 2026-08-09 22:17   ` Linus Walleij
  2026-08-10  8:36     ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2026-08-09 22:17 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Yao Qi, westeri, brgl, linux-gpio, linux-acpi, linux-kernel

On Sat, Aug 8, 2026 at 9:42 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

> > The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> > (Modern Standby) when suspended with an external HDMI display connected.
> >
> > This issue is caused by spurious ACPI event signaling routed through
> > GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> > system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> >
> > Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> > unwanted wakeups. This has been runtime-tested and verified using the
> > `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.
>
> If AMD people will be quick enough to tag this, I will include in my PR to
> Linus W. on next week.

To Bartosz?

It's gpiolib...

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM
  2026-08-09 22:17   ` Linus Walleij
@ 2026-08-10  8:36     ` Andy Shevchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-08-10  8:36 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Yao Qi, westeri, brgl, linux-gpio, linux-acpi, linux-kernel

On Mon, Aug 10, 2026 at 12:17:06AM +0200, Linus Walleij wrote:
> On Sat, Aug 8, 2026 at 9:42 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:
> 
> > > The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> > > (Modern Standby) when suspended with an external HDMI display connected.
> > >
> > > This issue is caused by spurious ACPI event signaling routed through
> > > GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> > > system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> > >
> > > Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> > > unwanted wakeups. This has been runtime-tested and verified using the
> > > `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.
> >
> > If AMD people will be quick enough to tag this, I will include in my PR to
> > Linus W. on next week.
> 
> To Bartosz?
> It's gpiolib...

Oh, true, I have also pin control stuff to send!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-10  8:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-08 15:55 [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM Yao Qi
2026-08-08 19:42 ` Andy Shevchenko
2026-08-09 22:17   ` Linus Walleij
2026-08-10  8:36     ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox