From: Conor Dooley <conor@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: devicetree@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Robinson <pbrobinson@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Rosen Penev <rosenp@gmail.com>
Subject: Re: [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible
Date: Tue, 8 Sep 2026 18:03:38 +0100 [thread overview]
Message-ID: <20260908-applaud-dallying-9027d7a8a598@spud> (raw)
In-Reply-To: <CAMRc=MdHUpmoFDtmXdbXnbS+_4ffBQcFLo9XjdO=jMom+getpg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]
On Tue, Sep 08, 2026 at 12:37:21AM -0700, Bartosz Golaszewski wrote:
> On Mon, 7 Sep 2026 18:54:12 +0200, Conor Dooley <conor@kernel.org> said:
> > On Fri, Sep 04, 2026 at 05:09:19PM -0700, Rosen Penev wrote:
> >> The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
> >> expander and is register-compatible with it. The addition of the
> >> compatible in the driver missed the documentation update.
> >
> > The commit message makes it sound like this device should use a
> > fallback. Why doesn't it? Either it should, or the commit message needs
> > an update.
> > pw-bot: changes-requested
> >
>
> Actually commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
> pca9655") added this compatible to the driver back in 2021 but it had remained
> undocumented until now. Unfortunately there's no denying I signed off on it. :(
Ye, but if patches like this appear for things that were undocumented
but ended up in drivers we still try to get the bindings correct when
they do show up. The commit message is basically telling me that this patch
is wrong and that a fallback to the pca9555 should be used. There's no
impact on the driver, so I don't see any harm in getting the binding
right.
> This commit should probably contain a Fixes: tag pointing at this commit.
Perhaps, but I'm not convinced that binding patches should ever have
Fixes tags citing drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-09-08 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 0:09 [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible Rosen Penev
2026-09-07 16:54 ` Conor Dooley
2026-09-08 7:37 ` Bartosz Golaszewski
2026-09-08 17:03 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908-applaud-dallying-9027d7a8a598@spud \
--to=conor@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox