[PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

[PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

[Rosen Penev]

The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
expander and is register-compatible with it. The addition of the
compatible in the driver missed the documentation update.

Fixes: 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi pca9655")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 4631388a7d91..563f61e6e543 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -67,6 +67,7 @@ properties:
               - nxp,pcal9555a
               - onnn,cat9554
               - onnn,pca9654
+              - onnn,pca9655
               - ti,pca6107
               - ti,pca9536
               - ti,tca6408
-- 
2.55.0

Re: [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

On Fri, Sep 04, 2026 at 05:09:19PM -0700, Rosen Penev wrote:
> The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
> expander and is register-compatible with it. The addition of the
> compatible in the driver missed the documentation update.

The commit message makes it sound like this device should use a
fallback. Why doesn't it? Either it should, or the commit message needs
an update.
pw-bot: changes-requested

Thanks,
Conor.

> 
> Fixes: 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi pca9655")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> index 4631388a7d91..563f61e6e543 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> @@ -67,6 +67,7 @@ properties:
>                - nxp,pcal9555a
>                - onnn,cat9554
>                - onnn,pca9654
> +              - onnn,pca9655
>                - ti,pca6107
>                - ti,pca9536
>                - ti,tca6408
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

[Bartosz Golaszewski]

On Mon, 7 Sep 2026 18:54:12 +0200, Conor Dooley <conor@kernel.org> said:
> On Fri, Sep 04, 2026 at 05:09:19PM -0700, Rosen Penev wrote:
>> The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
>> expander and is register-compatible with it. The addition of the
>> compatible in the driver missed the documentation update.
>
> The commit message makes it sound like this device should use a
> fallback. Why doesn't it? Either it should, or the commit message needs
> an update.
> pw-bot: changes-requested
>

Actually commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
pca9655") added this compatible to the driver back in 2021 but it had remained
undocumented until now. Unfortunately there's no denying I signed off on it. :(

This commit should probably contain a Fixes: tag pointing at this commit.

Bart

Re: [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On Tue, Sep 08, 2026 at 12:37:21AM -0700, Bartosz Golaszewski wrote:
> On Mon, 7 Sep 2026 18:54:12 +0200, Conor Dooley <conor@kernel.org> said:
> > On Fri, Sep 04, 2026 at 05:09:19PM -0700, Rosen Penev wrote:
> >> The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
> >> expander and is register-compatible with it. The addition of the
> >> compatible in the driver missed the documentation update.
> >
> > The commit message makes it sound like this device should use a
> > fallback. Why doesn't it? Either it should, or the commit message needs
> > an update.
> > pw-bot: changes-requested
> >
> 
> Actually commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
> pca9655") added this compatible to the driver back in 2021 but it had remained
> undocumented until now. Unfortunately there's no denying I signed off on it. :(

Ye, but if patches like this appear for things that were undocumented
but ended up in drivers we still try to get the bindings correct when
they do show up. The commit message is basically telling me that this patch
is wrong and that a fallback to the pca9555 should be used. There's no
impact on the driver, so I don't see any harm in getting the binding
right.

> This commit should probably contain a Fixes: tag pointing at this commit.

Perhaps, but I'm not convinced that binding patches should ever have
Fixes tags citing drivers.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]