* [PATCH v1 1/1] gpiolib: Put stubs in order in linux/gpio/driver.h
@ 2026-10-21 14:55 Andy Shevchenko
2026-10-22 8:18 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2026-10-21 14:55 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski
The stubs in linux/gpio/driver.h go in a slightly different order
than declarations. Put stubs in the same order.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/gpio/driver.h | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 7918b1575201..f3f913691a59 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -837,6 +837,17 @@ struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnod
#include <asm/bug.h>
+static inline int gpiochip_lock_as_irq(struct gpio_chip *gc, unsigned int offset)
+{
+ WARN_ON(1);
+ return -EINVAL;
+}
+
+static inline void gpiochip_unlock_as_irq(struct gpio_chip *gc, unsigned int offset)
+{
+ WARN_ON(1);
+}
+
static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
{
/* GPIO can never have been requested */
@@ -873,19 +884,6 @@ static inline struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode
WARN_ON(1);
return NULL;
}
-
-static inline int gpiochip_lock_as_irq(struct gpio_chip *gc,
- unsigned int offset)
-{
- WARN_ON(1);
- return -EINVAL;
-}
-
-static inline void gpiochip_unlock_as_irq(struct gpio_chip *gc,
- unsigned int offset)
-{
- WARN_ON(1);
-}
#endif /* CONFIG_GPIOLIB */
static inline bool fwnode_is_gpiochip(struct fwnode_handle *fwnode)
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] gpiolib: Put stubs in order in linux/gpio/driver.h
2026-10-21 14:55 [PATCH v1 1/1] gpiolib: Put stubs in order in linux/gpio/driver.h Andy Shevchenko
@ 2026-10-22 8:18 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2026-10-22 8:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel
On Wed, 21 Oct 2026 16:55:43 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> The stubs in linux/gpio/driver.h go in a slightly different order
> than declarations. Put stubs in the same order.
>
I see your OCD is worse than mine. :)
Though it doesn't apply on top of gpio/for-next.
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-22 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-21 14:55 [PATCH v1 1/1] gpiolib: Put stubs in order in linux/gpio/driver.h Andy Shevchenko
2026-10-22 8:18 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox