From: Mario Limonciello <superm1@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: mario.limonciello@amd.com, Basavaraj.Natikar@amd.com,
Shyam-sundar.S-k@amd.com, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: amd: Don't access irq_data's hwirq member directly
Date: Thu, 21 Aug 2025 10:46:55 -0500 [thread overview]
Message-ID: <21a552a5-d274-41d4-bb10-20615f44a102@kernel.org> (raw)
In-Reply-To: <aKc-eRIeLP3DOjQN@smile.fi.intel.com>
On 8/21/25 10:42 AM, Andy Shevchenko wrote:
> On Thu, Aug 21, 2025 at 09:49:11AM -0500, Mario Limonciello (AMD) wrote:
>> There is an irqd_to_hwirq() intended to get the hwirq number. Switch
>> all use to it.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
>
> ...
>
>> pm_pr_dbg("Setting wake for GPIO %lu to %s\n",
>> - d->hwirq, str_enable_disable(on));
>> + hwirq, str_enable_disable(on));
>
> Not related to this series, just wondering if it makes sense to have this to be
> in IRQ chip core (OTOH, it will not tell about GPIO per se, just about an IRQ
> chip).
>
It might be a bit noisy to be in the core. If it turns out that such a
message is valuable outside of debugging pinctrl-amd, no opposition to
moving it though in the future.
The existing pm_pr_dbg() messages used by pinctrl-amd have been
immensely helpful to find firmware bugs.
next prev parent reply other threads:[~2025-08-21 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:49 [PATCH v2] pinctrl: amd: Don't access irq_data's hwirq member directly Mario Limonciello (AMD)
2025-08-21 15:42 ` Andy Shevchenko
2025-08-21 15:46 ` Mario Limonciello [this message]
2025-08-21 22:16 ` Linus Walleij
2025-08-22 0:30 ` Mario Limonciello
2025-08-22 6:33 ` Linus Walleij
2025-08-22 7:53 ` Andy Shevchenko
2025-08-22 13:12 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a552a5-d274-41d4-bb10-20615f44a102@kernel.org \
--to=superm1@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox