From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mario Limonciello <superm1@kernel.org>,
mario.limonciello@amd.com, Basavaraj.Natikar@amd.com,
Shyam-sundar.S-k@amd.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: amd: Don't access irq_data's hwirq member directly
Date: Fri, 22 Aug 2025 10:53:48 +0300 [thread overview]
Message-ID: <aKgiDB29TxP5Kd9t@pixelbook> (raw)
In-Reply-To: <CACRpkdZKJ7BX8goR_6ik-ksDssFLQ8xw7SL06PpN0ZRNNccqgA@mail.gmail.com>
Fri, Aug 22, 2025 at 08:33:55AM +0200, Linus Walleij kirjoitti:
> On Fri, Aug 22, 2025 at 2:30 AM Mario Limonciello <superm1@kernel.org> wrote:
> > On 8/21/25 5:16 PM, Linus Walleij wrote:
> > > On Thu, Aug 21, 2025 at 4:49 PM Mario Limonciello (AMD)
> > > <superm1@kernel.org> wrote:
> > >
> > >> There is an irqd_to_hwirq() intended to get the hwirq number. Switch
> > >> all use to it.
> > >>
> > >> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> > >
> > > Hm where is this supposed to be applied...
> > > My tree?
> > >
> > > It doesn't currently apply to devel.
> > >
> > > Yours,
> > > Linus Walleij
> >
> > It was based off the commit that you picked up earlier this week. It
> > changes lines in that based upon Andy's feedback.
>
> Aha the single line pm_pr_debug() change. I applied that in
> fixes because it was just a oneliner and came with the other patch
> which was a fix.
>
> But this multiline non-regression can't go into fixes.
True, but fixes may go to the next if they are needed for dependent changes.
That's why there are three ways how to handle this:
- merge fixes to devel (That's how Mark Brown does, for example)
- merge next -rcX to devel (That's how Greg KH does, for example)
- cherry-pick fixes to devel (That's how I had done, when I was PDx86 maintainer).
- (4th one) wait till next release and proceed as usual (sometimes done by some
maintainers depending on the case at hand)
I believe we already had this discussion once or twice in the past for the
similar cases.
> I will move both of these over to -next since neither is
> a technical regression.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-22 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:49 [PATCH v2] pinctrl: amd: Don't access irq_data's hwirq member directly Mario Limonciello (AMD)
2025-08-21 15:42 ` Andy Shevchenko
2025-08-21 15:46 ` Mario Limonciello
2025-08-21 22:16 ` Linus Walleij
2025-08-22 0:30 ` Mario Limonciello
2025-08-22 6:33 ` Linus Walleij
2025-08-22 7:53 ` Andy Shevchenko [this message]
2025-08-22 13:12 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKgiDB29TxP5Kd9t@pixelbook \
--to=andy.shevchenko@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox