From: Song Chen <chensong_2000@189.cn>
To: Mark Brown <broonie@kernel.org>
Cc: krzk@kernel.org, lgirdwood@gmail.com, lee@kernel.org,
linus.walleij@linaro.org, brgl@bgdev.pl,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors
Date: Thu, 12 Dec 2024 14:01:45 +0800 [thread overview]
Message-ID: <26ca5498-e3b6-4ea3-a653-50114e5d7034@189.cn> (raw)
In-Reply-To: <8ecd5325-f347-4869-9049-2731b719f5d2@sirena.org.uk>
Thanks for reminding, will be corrected in next version.
Song
在 2024/12/11 21:25, Mark Brown 写道:
> On Wed, Dec 11, 2024 at 01:10:19PM +0800, Song Chen wrote:
>> This converts s5m8767 regulator driver to use GPIO descriptors.
>>
>> ---
>> v1 - v2:
>> 1, reedit commit message.
>> 2, remove development code.
>> 3, print error msg in dev_err_probe.
>> 4, doesn't set gpiod directions until successfully requesting
>> all gpiods. It's pretty much equivalent with original code.
>>
>> Signed-off-by: Song Chen <chensong_2000@189.cn>
>> ---
>
> Your signoff needs to be before the ---, and the changelog after the
> ---. The tools will get very confused and remove your signoff here.
next prev parent reply other threads:[~2024-12-12 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 5:10 [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors Song Chen
2024-12-11 13:25 ` Mark Brown
2024-12-12 6:01 ` Song Chen [this message]
2024-12-11 13:51 ` Bartosz Golaszewski
2024-12-12 5:55 ` Song Chen
2024-12-12 10:29 ` Bartosz Golaszewski
2024-12-13 10:25 ` Song Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26ca5498-e3b6-4ea3-a653-50114e5d7034@189.cn \
--to=chensong_2000@189.cn \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox