From: Song Chen <chensong_2000@189.cn>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: krzk@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
lee@kernel.org, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors
Date: Fri, 13 Dec 2024 18:25:18 +0800 [thread overview]
Message-ID: <e945f4e0-4256-40de-9946-c195b999bae8@189.cn> (raw)
In-Reply-To: <CAMRc=Medmy5EqTUWuQ-4YrQamOArKOK788iAY-=Cy42Od7y_Sw@mail.gmail.com>
Hi Bart,
在 2024/12/12 18:29, Bartosz Golaszewski 写道:
> On Thu, Dec 12, 2024 at 6:55 AM Song Chen <chensong_2000@189.cn> wrote:
>>
>> Or we can use devm_gpiod_get_array, it's pretty much equivalent effect
>> in s5m8767 even without fwnode specified.
>>
>
> Can you use it though? I was thinking you need the fwnode variant
> because it's the child (regulator) node of the device?
>
> If you can, that would be great.
>
> Bart
>
yes, i believe so, eventually both devm_gpiod_get_array and
devm_fwnode_gpiod_get_index use of_fwnode_handle(iodev->dev->of_node) in
this case.
But, i think it's a good idea to introduce a helper to get gpio
descriptor array with fwnode, i have made a patch, would appreciate it
if you can help me have a look.
Best regards,
Song
prev parent reply other threads:[~2024-12-13 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 5:10 [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors Song Chen
2024-12-11 13:25 ` Mark Brown
2024-12-12 6:01 ` Song Chen
2024-12-11 13:51 ` Bartosz Golaszewski
2024-12-12 5:55 ` Song Chen
2024-12-12 10:29 ` Bartosz Golaszewski
2024-12-13 10:25 ` Song Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e945f4e0-4256-40de-9946-c195b999bae8@189.cn \
--to=chensong_2000@189.cn \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox