* [PATCH] pinctrl: qcom: Move MODULE_DEVICE_TABLE next to the table itself
@ 2026-05-05 9:34 Krzysztof Kozlowski
2026-05-05 9:39 ` Konrad Dybcio
2026-05-05 12:54 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-05 9:34 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, linux-arm-msm, linux-gpio,
linux-kernel
Cc: Krzysztof Kozlowski
By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
exports, because this is easier to read and verify. It also makes more
sense since #ifdef for ACPI or OF could hide both of them.
Some Qualcomm pin controller drivers already have this correctly placed,
so adjust the other drivers. No functional impact.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
drivers/pinctrl/qcom/pinctrl-apq8064.c | 2 +-
drivers/pinctrl/qcom/pinctrl-apq8084.c | 2 +-
drivers/pinctrl/qcom/pinctrl-eliza.c | 2 +-
drivers/pinctrl/qcom/pinctrl-glymur.c | 2 +-
drivers/pinctrl/qcom/pinctrl-hawi.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ipq6018.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ipq8064.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ipq8074.c | 2 +-
drivers/pinctrl/qcom/pinctrl-kaanapali.c | 2 +-
drivers/pinctrl/qcom/pinctrl-mdm9607.c | 2 +-
drivers/pinctrl/qcom/pinctrl-mdm9615.c | 2 +-
drivers/pinctrl/qcom/pinctrl-milos.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8226.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8660.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8916.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8953.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8960.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8976.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8994.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8996.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8998.c | 2 +-
drivers/pinctrl/qcom/pinctrl-msm8x74.c | 2 +-
drivers/pinctrl/qcom/pinctrl-qcm2290.c | 2 +-
drivers/pinctrl/qcom/pinctrl-qcs404.c | 2 +-
drivers/pinctrl/qcom/pinctrl-qcs615.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sc7180.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sc7280.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sdm660.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sdm845.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sdx55.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sdx65.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm6115.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm6125.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm6350.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm6375.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8150.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8350.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8450.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8550.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8650.c | 2 +-
drivers/pinctrl/qcom/pinctrl-sm8750.c | 2 +-
drivers/pinctrl/qcom/pinctrl-x1e80100.c | 2 +-
44 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-apq8064.c b/drivers/pinctrl/qcom/pinctrl-apq8064.c
index 3654913f1ae5..a47f3d4f1ea5 100644
--- a/drivers/pinctrl/qcom/pinctrl-apq8064.c
+++ b/drivers/pinctrl/qcom/pinctrl-apq8064.c
@@ -622,6 +622,7 @@ static const struct of_device_id apq8064_pinctrl_of_match[] = {
{ .compatible = "qcom,apq8064-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, apq8064_pinctrl_of_match);
static struct platform_driver apq8064_pinctrl_driver = {
.driver = {
@@ -646,4 +647,3 @@ module_exit(apq8064_pinctrl_exit);
MODULE_AUTHOR("Bjorn Andersson <bjorn.andersson@sonymobile.com>");
MODULE_DESCRIPTION("Qualcomm APQ8064 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, apq8064_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-apq8084.c b/drivers/pinctrl/qcom/pinctrl-apq8084.c
index 9fdbe6743512..e3c1f86aba7d 100644
--- a/drivers/pinctrl/qcom/pinctrl-apq8084.c
+++ b/drivers/pinctrl/qcom/pinctrl-apq8084.c
@@ -1198,6 +1198,7 @@ static const struct of_device_id apq8084_pinctrl_of_match[] = {
{ .compatible = "qcom,apq8084-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, apq8084_pinctrl_of_match);
static struct platform_driver apq8084_pinctrl_driver = {
.driver = {
@@ -1221,4 +1222,3 @@ module_exit(apq8084_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm APQ8084 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, apq8084_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-eliza.c b/drivers/pinctrl/qcom/pinctrl-eliza.c
index c1f756cbcdeb..1eb690d07e18 100644
--- a/drivers/pinctrl/qcom/pinctrl-eliza.c
+++ b/drivers/pinctrl/qcom/pinctrl-eliza.c
@@ -1519,6 +1519,7 @@ static const struct of_device_id eliza_tlmm_of_match[] = {
{ .compatible = "qcom,eliza-tlmm", },
{},
};
+MODULE_DEVICE_TABLE(of, eliza_tlmm_of_match);
static struct platform_driver eliza_tlmm_driver = {
.driver = {
@@ -1542,4 +1543,3 @@ module_exit(eliza_tlmm_exit);
MODULE_DESCRIPTION("QTI Eliza TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, eliza_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c
index 9838c7839923..20f076e59375 100644
--- a/drivers/pinctrl/qcom/pinctrl-glymur.c
+++ b/drivers/pinctrl/qcom/pinctrl-glymur.c
@@ -1777,6 +1777,7 @@ static const struct of_device_id glymur_tlmm_of_match[] = {
{ .compatible = "qcom,mahua-tlmm", .data = &mahua_tlmm },
{ },
};
+MODULE_DEVICE_TABLE(of, glymur_tlmm_of_match);
static int glymur_tlmm_probe(struct platform_device *pdev)
{
@@ -1811,4 +1812,3 @@ module_exit(glymur_tlmm_exit);
MODULE_DESCRIPTION("QTI Glymur TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, glymur_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-hawi.c b/drivers/pinctrl/qcom/pinctrl-hawi.c
index 5c7894f3b9cb..cdde69e954a7 100644
--- a/drivers/pinctrl/qcom/pinctrl-hawi.c
+++ b/drivers/pinctrl/qcom/pinctrl-hawi.c
@@ -1584,6 +1584,7 @@ static const struct of_device_id hawi_tlmm_of_match[] = {
{ .compatible = "qcom,hawi-tlmm", },
{},
};
+MODULE_DEVICE_TABLE(of, hawi_tlmm_of_match);
static struct platform_driver hawi_tlmm_driver = {
.driver = {
@@ -1607,4 +1608,3 @@ module_exit(hawi_tlmm_exit);
MODULE_DESCRIPTION("QTI Hawi TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, hawi_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
index 05fdd73b951e..adf7c8631f72 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
@@ -702,6 +702,7 @@ static const struct of_device_id ipq4019_pinctrl_of_match[] = {
{ .compatible = "qcom,ipq4019-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, ipq4019_pinctrl_of_match);
static struct platform_driver ipq4019_pinctrl_driver = {
.driver = {
@@ -725,4 +726,3 @@ module_exit(ipq4019_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm ipq4019 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, ipq4019_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-ipq6018.c b/drivers/pinctrl/qcom/pinctrl-ipq6018.c
index cc83f9362a85..9a42e343ff17 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq6018.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq6018.c
@@ -1072,6 +1072,7 @@ static const struct of_device_id ipq6018_pinctrl_of_match[] = {
{ .compatible = "qcom,ipq6018-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, ipq6018_pinctrl_of_match);
static struct platform_driver ipq6018_pinctrl_driver = {
.driver = {
@@ -1095,4 +1096,3 @@ module_exit(ipq6018_pinctrl_exit);
MODULE_DESCRIPTION("QTI ipq6018 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, ipq6018_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8064.c b/drivers/pinctrl/qcom/pinctrl-ipq8064.c
index 0a9e357e64c6..78d320d56be6 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq8064.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq8064.c
@@ -624,6 +624,7 @@ static const struct of_device_id ipq8064_pinctrl_of_match[] = {
{ .compatible = "qcom,ipq8064-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, ipq8064_pinctrl_of_match);
static struct platform_driver ipq8064_pinctrl_driver = {
.driver = {
@@ -648,4 +649,3 @@ module_exit(ipq8064_pinctrl_exit);
MODULE_AUTHOR("Andy Gross <agross@codeaurora.org>");
MODULE_DESCRIPTION("Qualcomm IPQ8064 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, ipq8064_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8074.c b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
index 64ce8ea8f544..0b95f52adcc3 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq8074.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
@@ -1033,6 +1033,7 @@ static const struct of_device_id ipq8074_pinctrl_of_match[] = {
{ .compatible = "qcom,ipq8074-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, ipq8074_pinctrl_of_match);
static struct platform_driver ipq8074_pinctrl_driver = {
.driver = {
@@ -1056,4 +1057,3 @@ module_exit(ipq8074_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm ipq8074 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, ipq8074_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-kaanapali.c b/drivers/pinctrl/qcom/pinctrl-kaanapali.c
index 5cc45b9c55ab..e95ac064b84c 100644
--- a/drivers/pinctrl/qcom/pinctrl-kaanapali.c
+++ b/drivers/pinctrl/qcom/pinctrl-kaanapali.c
@@ -1774,6 +1774,7 @@ static const struct of_device_id kaanapali_tlmm_of_match[] = {
{ .compatible = "qcom,kaanapali-tlmm",},
{},
};
+MODULE_DEVICE_TABLE(of, kaanapali_tlmm_of_match);
static struct platform_driver kaanapali_tlmm_driver = {
.driver = {
@@ -1797,4 +1798,3 @@ module_exit(kaanapali_tlmm_exit);
MODULE_DESCRIPTION("QTI Kaanapali TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, kaanapali_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-mdm9607.c b/drivers/pinctrl/qcom/pinctrl-mdm9607.c
index 5794b0a11010..ce61eb415755 100644
--- a/drivers/pinctrl/qcom/pinctrl-mdm9607.c
+++ b/drivers/pinctrl/qcom/pinctrl-mdm9607.c
@@ -1050,6 +1050,7 @@ static const struct of_device_id mdm9607_pinctrl_of_match[] = {
{ .compatible = "qcom,mdm9607-tlmm", },
{ }
};
+MODULE_DEVICE_TABLE(of, mdm9607_pinctrl_of_match);
static struct platform_driver mdm9607_pinctrl_driver = {
.driver = {
@@ -1073,4 +1074,3 @@ module_exit(mdm9607_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm mdm9607 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, mdm9607_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-mdm9615.c b/drivers/pinctrl/qcom/pinctrl-mdm9615.c
index 729fe3d7e14e..f87e4d9a8f4f 100644
--- a/drivers/pinctrl/qcom/pinctrl-mdm9615.c
+++ b/drivers/pinctrl/qcom/pinctrl-mdm9615.c
@@ -439,6 +439,7 @@ static const struct of_device_id mdm9615_pinctrl_of_match[] = {
{ .compatible = "qcom,mdm9615-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, mdm9615_pinctrl_of_match);
static struct platform_driver mdm9615_pinctrl_driver = {
.driver = {
@@ -463,4 +464,3 @@ module_exit(mdm9615_pinctrl_exit);
MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
MODULE_DESCRIPTION("Qualcomm MDM9615 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, mdm9615_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-milos.c b/drivers/pinctrl/qcom/pinctrl-milos.c
index 74b5253257af..f5079a0ce0a3 100644
--- a/drivers/pinctrl/qcom/pinctrl-milos.c
+++ b/drivers/pinctrl/qcom/pinctrl-milos.c
@@ -1310,6 +1310,7 @@ static const struct of_device_id milos_tlmm_of_match[] = {
{ .compatible = "qcom,milos-tlmm" },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, milos_tlmm_of_match);
static struct platform_driver milos_tlmm_driver = {
.driver = {
@@ -1333,4 +1334,3 @@ module_exit(milos_tlmm_exit);
MODULE_DESCRIPTION("QTI Milos TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, milos_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8226.c b/drivers/pinctrl/qcom/pinctrl-msm8226.c
index d27b7599ea83..6f02e7c2499e 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8226.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8226.c
@@ -645,6 +645,7 @@ static const struct of_device_id msm8226_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8226-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8226_pinctrl_of_match);
static struct platform_driver msm8226_pinctrl_driver = {
.driver = {
@@ -669,4 +670,3 @@ module_exit(msm8226_pinctrl_exit);
MODULE_AUTHOR("Bartosz Dudziak <bartosz.dudziak@snejp.pl>");
MODULE_DESCRIPTION("Qualcomm MSM8226 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8226_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8660.c b/drivers/pinctrl/qcom/pinctrl-msm8660.c
index 5ded00396cd9..5b28a1c21a88 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8660.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8660.c
@@ -974,6 +974,7 @@ static const struct of_device_id msm8660_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8660-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8660_pinctrl_of_match);
static struct platform_driver msm8660_pinctrl_driver = {
.driver = {
@@ -998,4 +999,3 @@ module_exit(msm8660_pinctrl_exit);
MODULE_AUTHOR("Bjorn Andersson <bjorn.andersson@sonymobile.com>");
MODULE_DESCRIPTION("Qualcomm MSM8660 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8660_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8916.c b/drivers/pinctrl/qcom/pinctrl-msm8916.c
index 709c5d1d4d0a..d115035ff96a 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8916.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8916.c
@@ -960,6 +960,7 @@ static const struct of_device_id msm8916_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8916-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8916_pinctrl_of_match);
static struct platform_driver msm8916_pinctrl_driver = {
.driver = {
@@ -983,4 +984,3 @@ module_exit(msm8916_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm msm8916 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8916_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8953.c b/drivers/pinctrl/qcom/pinctrl-msm8953.c
index 02ea89f5feaa..d537fdaae148 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8953.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8953.c
@@ -1807,6 +1807,7 @@ static const struct of_device_id msm8953_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8953-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8953_pinctrl_of_match);
static struct platform_driver msm8953_pinctrl_driver = {
.driver = {
@@ -1830,4 +1831,3 @@ module_exit(msm8953_pinctrl_exit);
MODULE_DESCRIPTION("QTI msm8953 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8953_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8960.c b/drivers/pinctrl/qcom/pinctrl-msm8960.c
index 2fb15208aba0..a373150468ca 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8960.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8960.c
@@ -1239,6 +1239,7 @@ static const struct of_device_id msm8960_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8960-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8960_pinctrl_of_match);
static struct platform_driver msm8960_pinctrl_driver = {
.driver = {
@@ -1263,4 +1264,3 @@ module_exit(msm8960_pinctrl_exit);
MODULE_AUTHOR("Bjorn Andersson <bjorn.andersson@sonymobile.com>");
MODULE_DESCRIPTION("Qualcomm MSM8960 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8960_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
index 906a90778b97..bba3c87d8144 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
@@ -1087,6 +1087,7 @@ static const struct of_device_id msm8976_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8976-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8976_pinctrl_of_match);
static struct platform_driver msm8976_pinctrl_driver = {
.driver = {
@@ -1110,4 +1111,3 @@ module_exit(msm8976_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm msm8976 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8976_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8994.c b/drivers/pinctrl/qcom/pinctrl-msm8994.c
index ecbe6b91d1da..fdaa67c5869f 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8994.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8994.c
@@ -1334,6 +1334,7 @@ static const struct of_device_id msm8994_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8994-pinctrl", },
{ }
};
+MODULE_DEVICE_TABLE(of, msm8994_pinctrl_of_match);
static struct platform_driver msm8994_pinctrl_driver = {
.driver = {
@@ -1357,4 +1358,3 @@ module_exit(msm8994_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm MSM8994 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8994_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8996.c b/drivers/pinctrl/qcom/pinctrl-msm8996.c
index 73b07a10a957..332b18a8fa9c 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8996.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8996.c
@@ -1911,6 +1911,7 @@ static const struct of_device_id msm8996_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8996-pinctrl", },
{ }
};
+MODULE_DEVICE_TABLE(of, msm8996_pinctrl_of_match);
static struct platform_driver msm8996_pinctrl_driver = {
.driver = {
@@ -1934,4 +1935,3 @@ module_exit(msm8996_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm msm8996 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8996_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8998.c b/drivers/pinctrl/qcom/pinctrl-msm8998.c
index dcf11b79e562..0552c8212b29 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8998.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8998.c
@@ -1525,6 +1525,7 @@ static const struct of_device_id msm8998_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8998-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8998_pinctrl_of_match);
static struct platform_driver msm8998_pinctrl_driver = {
.driver = {
@@ -1548,4 +1549,3 @@ module_exit(msm8998_pinctrl_exit);
MODULE_DESCRIPTION("QTI msm8998 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8998_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8x74.c b/drivers/pinctrl/qcom/pinctrl-msm8x74.c
index ff432ec5815a..9422629ec6ca 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8x74.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8x74.c
@@ -1073,6 +1073,7 @@ static const struct of_device_id msm8x74_pinctrl_of_match[] = {
{ .compatible = "qcom,msm8974-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, msm8x74_pinctrl_of_match);
static struct platform_driver msm8x74_pinctrl_driver = {
.driver = {
@@ -1097,5 +1098,4 @@ module_exit(msm8x74_pinctrl_exit);
MODULE_AUTHOR("Bjorn Andersson <bjorn.andersson@sonymobile.com>");
MODULE_DESCRIPTION("Qualcomm MSM8x74 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, msm8x74_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-qcm2290.c b/drivers/pinctrl/qcom/pinctrl-qcm2290.c
index 3b28ac498885..d20b5bd329fb 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcm2290.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcm2290.c
@@ -1124,6 +1124,7 @@ static const struct of_device_id qcm2290_pinctrl_of_match[] = {
{ .compatible = "qcom,qcm2290-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, qcm2290_pinctrl_of_match);
static struct platform_driver qcm2290_pinctrl_driver = {
.driver = {
@@ -1147,4 +1148,3 @@ module_exit(qcm2290_pinctrl_exit);
MODULE_DESCRIPTION("QTI QCM2290 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, qcm2290_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-qcs404.c b/drivers/pinctrl/qcom/pinctrl-qcs404.c
index 1048a7093b2e..01c0f0b2839a 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcs404.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcs404.c
@@ -1635,6 +1635,7 @@ static const struct of_device_id qcs404_pinctrl_of_match[] = {
{ .compatible = "qcom,qcs404-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, qcs404_pinctrl_of_match);
static struct platform_driver qcs404_pinctrl_driver = {
.driver = {
@@ -1658,4 +1659,3 @@ module_exit(qcs404_pinctrl_exit);
MODULE_DESCRIPTION("Qualcomm QCS404 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, qcs404_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-qcs615.c b/drivers/pinctrl/qcom/pinctrl-qcs615.c
index 0ed4332d989e..9b4b95771d0b 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcs615.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcs615.c
@@ -1073,6 +1073,7 @@ static const struct of_device_id qcs615_tlmm_of_match[] = {
},
{},
};
+MODULE_DEVICE_TABLE(of, qcs615_tlmm_of_match);
static int qcs615_tlmm_probe(struct platform_device *pdev)
{
@@ -1101,4 +1102,3 @@ module_exit(qcs615_tlmm_exit);
MODULE_DESCRIPTION("QTI QCS615 TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, qcs615_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7180.c b/drivers/pinctrl/qcom/pinctrl-sc7180.c
index 01cfcb416f33..a02a9a78a557 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7180.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7180.c
@@ -1148,6 +1148,7 @@ static const struct of_device_id sc7180_pinctrl_of_match[] = {
{ .compatible = "qcom,sc7180-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sc7180_pinctrl_of_match);
static struct platform_driver sc7180_pinctrl_driver = {
.driver = {
@@ -1172,4 +1173,3 @@ module_exit(sc7180_pinctrl_exit);
MODULE_DESCRIPTION("QTI sc7180 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sc7180_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
index f22fd56efd89..bb32a56649df 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
@@ -1494,6 +1494,7 @@ static const struct of_device_id sc7280_pinctrl_of_match[] = {
{ .compatible = "qcom,sc7280-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sc7280_pinctrl_of_match);
static struct platform_driver sc7280_pinctrl_driver = {
.driver = {
@@ -1518,4 +1519,3 @@ module_exit(sc7280_pinctrl_exit);
MODULE_DESCRIPTION("QTI sc7280 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sc7280_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c b/drivers/pinctrl/qcom/pinctrl-sdm660.c
index ab0368653d30..c4a1ec90a341 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdm660.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
@@ -1433,6 +1433,7 @@ static const struct of_device_id sdm660_pinctrl_of_match[] = {
{ .compatible = "qcom,sdm630-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sdm660_pinctrl_of_match);
static struct platform_driver sdm660_pinctrl_driver = {
.driver = {
@@ -1456,4 +1457,3 @@ module_exit(sdm660_pinctrl_exit);
MODULE_DESCRIPTION("QTI sdm660 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sdm660_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c
index b5ed2311b70e..48fbe3623e17 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdm845.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c
@@ -1339,6 +1339,7 @@ static const struct of_device_id sdm845_pinctrl_of_match[] = {
{ .compatible = "qcom,sdm845-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sdm845_pinctrl_of_match);
static struct platform_driver sdm845_pinctrl_driver = {
.driver = {
@@ -1364,4 +1365,3 @@ module_exit(sdm845_pinctrl_exit);
MODULE_DESCRIPTION("QTI sdm845 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sdm845_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sdx55.c b/drivers/pinctrl/qcom/pinctrl-sdx55.c
index 3e87f5927924..656a0726db92 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdx55.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdx55.c
@@ -981,6 +981,7 @@ static const struct of_device_id sdx55_pinctrl_of_match[] = {
{ .compatible = "qcom,sdx55-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sdx55_pinctrl_of_match);
static struct platform_driver sdx55_pinctrl_driver = {
.driver = {
@@ -1004,4 +1005,3 @@ module_exit(sdx55_pinctrl_exit);
MODULE_DESCRIPTION("QTI sdx55 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sdx55_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sdx65.c b/drivers/pinctrl/qcom/pinctrl-sdx65.c
index 4e787341b2a2..dde8993ca9b1 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdx65.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdx65.c
@@ -929,6 +929,7 @@ static const struct of_device_id sdx65_pinctrl_of_match[] = {
{ .compatible = "qcom,sdx65-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, sdx65_pinctrl_of_match);
static struct platform_driver sdx65_pinctrl_driver = {
.driver = {
@@ -952,4 +953,3 @@ module_exit(sdx65_pinctrl_exit);
MODULE_DESCRIPTION("QTI sdx65 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sdx65_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm6115.c b/drivers/pinctrl/qcom/pinctrl-sm6115.c
index 234451fbf47b..e36716514f1f 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm6115.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm6115.c
@@ -897,6 +897,7 @@ static const struct of_device_id sm6115_tlmm_of_match[] = {
{ .compatible = "qcom,sm6115-tlmm", },
{ }
};
+MODULE_DEVICE_TABLE(of, sm6115_tlmm_of_match);
static struct platform_driver sm6115_tlmm_driver = {
.driver = {
@@ -920,4 +921,3 @@ module_exit(sm6115_tlmm_exit);
MODULE_DESCRIPTION("QTI sm6115 tlmm driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm6115_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm6125.c b/drivers/pinctrl/qcom/pinctrl-sm6125.c
index 2cf9136860fc..7447ef9a4931 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm6125.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm6125.c
@@ -1256,6 +1256,7 @@ static const struct of_device_id sm6125_tlmm_of_match[] = {
{ .compatible = "qcom,sm6125-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, sm6125_tlmm_of_match);
static struct platform_driver sm6125_tlmm_driver = {
.driver = {
@@ -1279,4 +1280,3 @@ module_exit(sm6125_tlmm_exit);
MODULE_DESCRIPTION("QTI sm6125 TLMM driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm6125_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm6350.c b/drivers/pinctrl/qcom/pinctrl-sm6350.c
index eb8cd4aa8a97..4089c96ff736 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm6350.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm6350.c
@@ -1363,6 +1363,7 @@ static const struct of_device_id sm6350_tlmm_of_match[] = {
{ .compatible = "qcom,sm6350-tlmm" },
{ },
};
+MODULE_DEVICE_TABLE(of, sm6350_tlmm_of_match);
static struct platform_driver sm6350_tlmm_driver = {
.driver = {
@@ -1386,4 +1387,3 @@ module_exit(sm6350_tlmm_exit);
MODULE_DESCRIPTION("QTI SM6350 TLMM driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm6350_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm6375.c b/drivers/pinctrl/qcom/pinctrl-sm6375.c
index d4547dd9f21f..8da71d940b90 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm6375.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm6375.c
@@ -1506,6 +1506,7 @@ static const struct of_device_id sm6375_tlmm_of_match[] = {
{ .compatible = "qcom,sm6375-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, sm6375_tlmm_of_match);
static struct platform_driver sm6375_tlmm_driver = {
.driver = {
@@ -1529,4 +1530,3 @@ module_exit(sm6375_tlmm_exit);
MODULE_DESCRIPTION("QTI SM6375 TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, sm6375_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c
index 0767261f5149..3c29de948034 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8150.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c
@@ -1532,6 +1532,7 @@ static const struct of_device_id sm8150_pinctrl_of_match[] = {
{ .compatible = "qcom,sm8150-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sm8150_pinctrl_of_match);
static struct platform_driver sm8150_pinctrl_driver = {
.driver = {
@@ -1555,4 +1556,3 @@ module_exit(sm8150_pinctrl_exit);
MODULE_DESCRIPTION("QTI sm8150 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm8150_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
index f73f3b052de4..abf5f68ef62f 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
@@ -1354,6 +1354,7 @@ static const struct of_device_id sm8250_pinctrl_of_match[] = {
{ .compatible = "qcom,sm8250-pinctrl", },
{ },
};
+MODULE_DEVICE_TABLE(of, sm8250_pinctrl_of_match);
static struct platform_driver sm8250_pinctrl_driver = {
.driver = {
@@ -1377,4 +1378,3 @@ module_exit(sm8250_pinctrl_exit);
MODULE_DESCRIPTION("QTI sm8250 pinctrl driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm8250_pinctrl_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
index 377ddfc77e4f..8bd278c97171 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
@@ -1632,6 +1632,7 @@ static const struct of_device_id sm8350_tlmm_of_match[] = {
{ .compatible = "qcom,sm8350-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, sm8350_tlmm_of_match);
static struct platform_driver sm8350_tlmm_driver = {
.driver = {
@@ -1655,4 +1656,3 @@ module_exit(sm8350_tlmm_exit);
MODULE_DESCRIPTION("QTI SM8350 TLMM driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm8350_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8450.c b/drivers/pinctrl/qcom/pinctrl-sm8450.c
index a1d84074ea49..8ca5b6e15e6c 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8450.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8450.c
@@ -1667,6 +1667,7 @@ static const struct of_device_id sm8450_tlmm_of_match[] = {
{ .compatible = "qcom,sm8450-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, sm8450_tlmm_of_match);
static struct platform_driver sm8450_tlmm_driver = {
.driver = {
@@ -1690,4 +1691,3 @@ module_exit(sm8450_tlmm_exit);
MODULE_DESCRIPTION("QTI SM8450 TLMM driver");
MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, sm8450_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8550.c b/drivers/pinctrl/qcom/pinctrl-sm8550.c
index cc8fbf4d5e84..d12256d970a0 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8550.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8550.c
@@ -1752,6 +1752,7 @@ static const struct of_device_id sm8550_tlmm_of_match[] = {
{ .compatible = "qcom,sm8550-tlmm", },
{},
};
+MODULE_DEVICE_TABLE(of, sm8550_tlmm_of_match);
static struct platform_driver sm8550_tlmm_driver = {
.driver = {
@@ -1775,4 +1776,3 @@ module_exit(sm8550_tlmm_exit);
MODULE_DESCRIPTION("QTI SM8550 TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, sm8550_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8650.c b/drivers/pinctrl/qcom/pinctrl-sm8650.c
index ab41292e3b4e..cf57d226c47f 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8650.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8650.c
@@ -1732,6 +1732,7 @@ static const struct of_device_id sm8650_tlmm_of_match[] = {
{ .compatible = "qcom,sm8650-tlmm", },
{},
};
+MODULE_DEVICE_TABLE(of, sm8650_tlmm_of_match);
static struct platform_driver sm8650_tlmm_driver = {
.driver = {
@@ -1755,4 +1756,3 @@ module_exit(sm8650_tlmm_exit);
MODULE_DESCRIPTION("QTI SM8650 TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, sm8650_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8750.c b/drivers/pinctrl/qcom/pinctrl-sm8750.c
index 4cfe73f30fac..f27e55c088d5 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8750.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8750.c
@@ -1701,6 +1701,7 @@ static const struct of_device_id sm8750_tlmm_of_match[] = {
{ .compatible = "qcom,sm8750-tlmm", },
{},
};
+MODULE_DEVICE_TABLE(of, sm8750_tlmm_of_match);
static struct platform_driver sm8750_tlmm_driver = {
.driver = {
@@ -1724,4 +1725,3 @@ module_exit(sm8750_tlmm_exit);
MODULE_DESCRIPTION("QTI SM8750 TLMM driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, sm8750_tlmm_of_match);
diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
index a9fe75fc45e5..8d2b8246170b 100644
--- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c
+++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
@@ -1851,6 +1851,7 @@ static const struct of_device_id x1e80100_pinctrl_of_match[] = {
{ .compatible = "qcom,x1e80100-tlmm", },
{ },
};
+MODULE_DEVICE_TABLE(of, x1e80100_pinctrl_of_match);
static struct platform_driver x1e80100_pinctrl_driver = {
.driver = {
@@ -1874,4 +1875,3 @@ module_exit(x1e80100_pinctrl_exit);
MODULE_DESCRIPTION("QTI X1E80100 TLMM pinctrl driver");
MODULE_LICENSE("GPL");
-MODULE_DEVICE_TABLE(of, x1e80100_pinctrl_of_match);
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: Move MODULE_DEVICE_TABLE next to the table itself
2026-05-05 9:34 [PATCH] pinctrl: qcom: Move MODULE_DEVICE_TABLE next to the table itself Krzysztof Kozlowski
@ 2026-05-05 9:39 ` Konrad Dybcio
2026-05-05 12:54 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-05-05 9:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Linus Walleij,
linux-arm-msm, linux-gpio, linux-kernel
On 5/5/26 11:34 AM, Krzysztof Kozlowski wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify. It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
>
> Some Qualcomm pin controller drivers already have this correctly placed,
> so adjust the other drivers. No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: Move MODULE_DEVICE_TABLE next to the table itself
2026-05-05 9:34 [PATCH] pinctrl: qcom: Move MODULE_DEVICE_TABLE next to the table itself Krzysztof Kozlowski
2026-05-05 9:39 ` Konrad Dybcio
@ 2026-05-05 12:54 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2026-05-05 12:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-arm-msm, linux-gpio, linux-kernel
On Tue, May 5, 2026 at 11:34 AM Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify. It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
>
> Some Qualcomm pin controller drivers already have this correctly placed,
> so adjust the other drivers. No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patch applied.
Some newly merged drivers may be missed, check linux-next.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-05 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-05 9:34 [PATCH] pinctrl: qcom: Move MODULE_DEVICE_TABLE next to the table itself Krzysztof Kozlowski
2026-05-05 9:39 ` Konrad Dybcio
2026-05-05 12:54 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox