Re: [PATCH] pinctrl: cherryview: Trigger hwirq0 for interrupt-lines without a mapping

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 1/11/22 21:40, Andy Shevchenko wrote:
> On Tue, Jan 04, 2022 at 05:42:38PM +0100, Hans de Goede wrote:
>> Commit bdfbef2d29dc ("pinctrl: cherryview: Don't use selection 0 to mark
>> an interrupt line as unused") made the code properly differentiate
>> between unset vs (hwirq) 0 entries in the GPIO-controller interrupt-line
>> to GPIO pinnumber/hwirq mapping.
>>
>> This is causing some boards to not boot. This commit restores the old
>> behavior of triggering hwirq 0 when receiving an interrupt on an
>> interrupt-line for which there is no mapping.
> 
> I conducted a research and, on the board Jarkko has issues with, all
> mentioned pins are floating.
> 
> [    3.556875] cherryview-pinctrl INT33FF:00: interrupt on unmapped interrupt line 0
> (I believe this matches to 76 below)
> 
> [   37.287821] cherryview-pinctrl INT33FF:03: using interrupt line 0 for pin 81
> [   37.371456] cherryview-pinctrl INT33FF:02: using interrupt line 0 for pin 22
> [   37.389548] cherryview-pinctrl INT33FF:03: using interrupt line 2 for pin 77
> [   37.407050] cherryview-pinctrl INT33FF:00: using interrupt line 0 for pin 76
> 
> Two of them are designated for SD card and Audio Daughter board.
> But in all cases is seems like PCB error, unfortunately.

Ok, thank you for looking into this.

Regards,

Hans