From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: linux-gpio@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] pinctrl: tb10x: Mark base as __iomem
Date: Tue, 30 Jun 2026 14:24:29 +0200 [thread overview]
Message-ID: <68fffe3a-42da-4746-85f3-d2c6d0235a5d@kernel.org> (raw)
In-Reply-To: <20260630-tb10x-v1-1-5d08d2dd3240@kernel.org>
On 30/06/2026 13:34, Linus Walleij wrote:
> The compile tests are complaining that this is not correctly typed.
>
> Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")
I do not think this is a correct fixes tag. The issue was introduced by
whichever commit made iomem memory a plain pointer.
Issue was reproducible earlier, just not on x86.
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606150641.cbQ05ZMM-lkp@intel.com/
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
> drivers/pinctrl/pinctrl-tb10x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c
> index 3f581404a9b9..b7cbd69dd877 100644
> --- a/drivers/pinctrl/pinctrl-tb10x.c
> +++ b/drivers/pinctrl/pinctrl-tb10x.c
> @@ -479,7 +479,7 @@ struct tb10x_port {
> */
> struct tb10x_pinctrl {
> struct pinctrl_dev *pctl;
> - void *base;
> + void __iomem *base;
Best regards,
Krzysztof
prev parent reply other threads:[~2026-06-30 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 11:34 [PATCH] pinctrl: tb10x: Mark base as __iomem Linus Walleij
2026-06-30 12:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68fffe3a-42da-4746-85f3-d2c6d0235a5d@kernel.org \
--to=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox