[PATCH] pinctrl: tb10x: Mark base as __iomem

[PATCH] pinctrl: tb10x: Mark base as __iomem

[Linus Walleij]

The compile tests are complaining that this is not correctly typed.

Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202606150641.cbQ05ZMM-lkp@intel.com/
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
 drivers/pinctrl/pinctrl-tb10x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c
index 3f581404a9b9..b7cbd69dd877 100644
--- a/drivers/pinctrl/pinctrl-tb10x.c
+++ b/drivers/pinctrl/pinctrl-tb10x.c
@@ -479,7 +479,7 @@ struct tb10x_port {
  */
 struct tb10x_pinctrl {
 	struct pinctrl_dev *pctl;
-	void *base;
+	void __iomem *base;
 	const struct tb10x_pinfuncgrp *pingroups;
 	unsigned int pinfuncgrpcnt;
 	unsigned int pinfuncnt;

---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260630-tb10x-0360d5489542

Best regards,
--  
Linus Walleij <linusw@kernel.org>

Re: [PATCH] pinctrl: tb10x: Mark base as __iomem

[Krzysztof Kozlowski]

On 30/06/2026 13:34, Linus Walleij wrote:
> The compile tests are complaining that this is not correctly typed.
> 
> Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")

I do not think this is a correct fixes tag. The issue was introduced by
whichever commit made iomem memory a plain pointer.

Issue was reproducible earlier, just not on x86.

> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606150641.cbQ05ZMM-lkp@intel.com/
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
>  drivers/pinctrl/pinctrl-tb10x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c
> index 3f581404a9b9..b7cbd69dd877 100644
> --- a/drivers/pinctrl/pinctrl-tb10x.c
> +++ b/drivers/pinctrl/pinctrl-tb10x.c
> @@ -479,7 +479,7 @@ struct tb10x_port {
>   */
>  struct tb10x_pinctrl {
>  	struct pinctrl_dev *pctl;
> -	void *base;
> +	void __iomem *base;


Best regards,
Krzysztof