Re: [PATCH 5/5] soc: mediatek: mtk-pmic-wrap: Drop CAP reset in MT6765

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 29/07/24 09:34, Arseniy Velikanov ha scritto:
> None of the MT6765 reset-controllers have PWRAP reset,
> so remove the requirement of it

Sorry, but that's not true. There is indeed a reset bit for the PWRAP on MT6765.

Which one and where - I have no idea, but I'm sure that there is one :-)

Cheers,
Angelo

> 
> Fixes: 12b079b0fe8b ("soc: mediatek: pwrap: add pwrap driver for mt6765 SoCs")
> Signed-off-by: Arseniy Velikanov <me@adomerle.xyz>
> ---
>   drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index efd9cae212dc..30d74279e27f 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2288,7 +2288,7 @@ static const struct pmic_wrapper_type pwrap_mt6765 = {
>   	.int_en_all = 0xffffffff,
>   	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>   	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
> -	.caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
> +	.caps = PWRAP_CAP_DCM,
>   	.init_reg_clock = pwrap_common_init_reg_clock,
>   	.init_soc_specific = NULL,
>   };