From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arseniy Velikanov <me@adomerle.xyz>,
mturquette@baylibre.com, sboyd@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
sean.wang@kernel.org, linus.walleij@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, frank.li@vivo.com,
jiasheng@iscas.ac.cn, mars.cheng@mediatek.com,
owen.chen@mediatek.com, macpaul.lin@mediatek.com,
zh.chen@mediatek.com, argus.lin@mediatek.com
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: pinctrl: mediatek: Add bindings for MT6765 pin controller
Date: Mon, 29 Jul 2024 09:39:31 +0200 [thread overview]
Message-ID: <aada1945-6351-4f5e-9f98-0d6640ba3b6b@kernel.org> (raw)
In-Reply-To: <20240729073428.28983-5-me@adomerle.xyz>
On 29/07/2024 09:34, Arseniy Velikanov wrote:
> Add DT bindings for the MT6765 pin controller, which consist of macros
By bindings we usually understand something else, which is clearly
missing here: the documentation or bindings expressed as DT schema.
So where are the bindings, except header constants?
Also, why are these exactly bindings? I do not see them being used in
the driver, so probably you placed them in wrong directory - you wanted
DTS header constants?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 7:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 7:34 [PATCH 0/5] Initial preparations for MT6765 Arseniy Velikanov
2024-07-29 7:34 ` [PATCH 1/5] dt-bindings: clock: mt6765: Add missing PMIC clock Arseniy Velikanov
2024-07-29 7:36 ` Krzysztof Kozlowski
2024-07-29 7:46 ` AngeloGioacchino Del Regno
2024-07-29 7:34 ` [PATCH 2/5] clk: mediatek: " Arseniy Velikanov
2024-07-29 7:46 ` AngeloGioacchino Del Regno
2024-07-29 7:34 ` [PATCH 3/5] pinctrl: mediatek: mt6765: Add virtual GPIOs Arseniy Velikanov
2024-07-29 7:46 ` AngeloGioacchino Del Regno
2024-07-29 7:34 ` [PATCH 4/5] dt-bindings: pinctrl: mediatek: Add bindings for MT6765 pin controller Arseniy Velikanov
2024-07-29 7:39 ` Krzysztof Kozlowski [this message]
2024-07-29 7:46 ` AngeloGioacchino Del Regno
2024-07-29 7:34 ` [PATCH 5/5] soc: mediatek: mtk-pmic-wrap: Drop CAP reset in MT6765 Arseniy Velikanov
2024-07-29 7:48 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aada1945-6351-4f5e-9f98-0d6640ba3b6b@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=argus.lin@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@vivo.com \
--cc=jiasheng@iscas.ac.cn \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=me@adomerle.xyz \
--cc=mturquette@baylibre.com \
--cc=owen.chen@mediatek.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
--cc=zh.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox