[PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA

[PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA

[Masahiro Yamada]

CONFIG_PINCTRL_PXA is more suitable than CONFIG_ARCH_PXA
to guard the drivers/pinctrl/pxa/ directory.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/pinctrl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index b7b456a..04b633f 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -40,7 +40,7 @@ obj-y				+= freescale/
 obj-$(CONFIG_X86)		+= intel/
 obj-$(CONFIG_PINCTRL_MVEBU)	+= mvebu/
 obj-y				+= nomadik/
-obj-$(CONFIG_ARCH_PXA)		+= pxa/
+obj-$(CONFIG_PINCTRL_PXA)	+= pxa/
 obj-$(CONFIG_ARCH_QCOM)		+= qcom/
 obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
 obj-$(CONFIG_PINCTRL_SH_PFC)	+= sh-pfc/
-- 
1.9.1

Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Hi Masahiro,

[auto build test ERROR on next-20160122]
[cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Masahiro-Yamada/pinctrl-pxa-guard-sub-directory-with-CONFIG_PINCTRL_PXA/20160123-233501
config: x86_64-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 53158 bytes --]

Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA

[Masahiro Yamada]

2016-01-24 2:56 GMT+09:00 kbuild test robot <lkp@intel.com>:
> Hi Masahiro,
>
> [auto build test ERROR on next-20160122]
> [cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/Masahiro-Yamada/pinctrl-pxa-guard-sub-directory-with-CONFIG_PINCTRL_PXA/20160123-233501
> config: x86_64-allmodconfig (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


driver/pinctrl/pxa/ has never been compile-tested before,
and it has just unveiled some issues of this driver.


[1]  driver/pinctrl/pxa/ has not been activated yet,
so I posted this:
https://patchwork.kernel.org/patch/8097771/


[2]  this driver is declared as tristate, but it cannot be a module,
so I posted this:
https://patchwork.kernel.org/patch/8097781/




I hope [2] will be applied before this patch
in order to suppress the complaint by the kbuild test robot.



-- 
Best Regards
Masahiro Yamada

Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA

[Robert Jarzmik]

Masahiro Yamada <yamada.masahiro@socionext.com> writes:

> 2016-01-24 2:56 GMT+09:00 kbuild test robot <lkp@intel.com>:
>> Hi Masahiro,
>>
>> [auto build test ERROR on next-20160122]
>> [cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/Masahiro-Yamada/pinctrl-pxa-guard-sub-directory-with-CONFIG_PINCTRL_PXA/20160123-233501
>> config: x86_64-allmodconfig (attached as .config)
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=x86_64
>>
>> All errors (new ones prefixed by >>):
>>
>>>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>
>
> driver/pinctrl/pxa/ has never been compile-tested before,
It was, and runtime tested also, in a builtin form. It was not activated in the
kernel at the arch/arm pxa architecture level would be a better statement.

> [2]  this driver is declared as tristate, but it cannot be a module,
> so I posted this:
> https://patchwork.kernel.org/patch/8097781/
Yes this certainly is a bug.

> I hope [2] will be applied before this patch
> in order to suppress the complaint by the kbuild test robot.
Let's see what Linus thinks of it.

Cheers.

-- 
Robert

Re: [PATCH] pinctrl: pxa: guard sub-directory with CONFIG_PINCTRL_PXA

[Linus Walleij]

On Sat, Jan 23, 2016 at 4:31 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> CONFIG_PINCTRL_PXA is more suitable than CONFIG_ARCH_PXA
> to guard the drivers/pinctrl/pxa/ directory.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied.

Yours,
Linus Walleij