Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Hardik Prakash <hardikprakash.official@gmail.com>,
	linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
	wsa@kernel.org, andriy.shevchenko@intel.com,
	basavaraj.natikar@amd.com, linus.walleij@linaro.org
Subject: Re: [PATCH v5 0/1] i2c: designware: fix probe ordering for AMD GPIO on Lenovo Yoga 7 14AGP11
Date: Mon, 18 May 2026 09:08:29 -0500	[thread overview]
Message-ID: <9d5da93e-bbe0-4359-9f17-e3c6b3a5cb34@amd.com> (raw)
In-Reply-To: <CAMRc=MdS_BVKb=FQLhky=8dpghBSoHeBhUk0LM5hROFxmJeyGQ@mail.gmail.com>



On 5/18/26 09:05, Bartosz Golaszewski wrote:
> On Mon, May 18, 2026 at 3:46 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>>
>>
>> On 5/18/26 08:40, Hardik Prakash wrote:
>>> On Mon, May 18, 2026 at 18:17, Mario Limonciello wrote:
>>>> I'd still like to avoid a quirk if we can.
>>>>
>>>> I know my proposed patch to try to probe at an earlier stage didn't
>>>> work, but could you perhaps try pulling pinctrl-amd even earlier?
>>>>
>>>> Maybe fs_initcall()?
>>>
>>> Tested. fs_initcall + patch 1 still produces the same arbitration
>>> errors:
>>>
>>>     subsys_initcall + patch 1:   arbitration errors persist
>>>     fs_initcall + patch 1:       arbitration errors persist
>>>     patch 1 + patch 2 (v5):     clean boot, touchscreen fully functional
>>>
>>> The initcall level does not appear to be the determining factor on
>>> this hardware. i2c_designware is still probing AMDI0010:02 before
>>> pinctrl-amd finishes regardless of how early pinctrl-amd registers.
>>> The explicit device_is_bound() deferral in patch 2 is the only
>>> approach that has worked.
>>
>> Please try arch_initcall instead.
>>
> 
> What is blocking the pinctrl driver from probing? Does it return
> -EPROBE_DEFER for some reason? Pin control core is ready at
> core_initcall() so it should work in theory.
> 
> Bart

Currently it's module_platform_driver() IE device_initcall().

That's why I think we "should" be able to move it a lot earlier.

  reply	other threads:[~2026-05-18 14:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 12:28 [PATCH v5 0/1] i2c: designware: fix probe ordering for AMD GPIO on Lenovo Yoga 7 14AGP11 Hardik Prakash
2026-05-18 12:28 ` [PATCH v5 1/1] " Hardik Prakash
2026-05-18 12:47 ` [PATCH v5 0/1] " Mario Limonciello
2026-05-18 13:40   ` Hardik Prakash
2026-05-18 13:45     ` Mario Limonciello
2026-05-18 14:05       ` Bartosz Golaszewski
2026-05-18 14:08         ` Mario Limonciello [this message]
2026-05-18 14:10           ` Bartosz Golaszewski
2026-05-18 14:23             ` Hardik Prakash
2026-05-18 14:26               ` Bartosz Golaszewski
2026-05-18 14:27               ` Andy Shevchenko
2026-05-18 17:22                 ` Hardik Prakash
2026-05-18 17:44                   ` Mario Limonciello
2026-05-19  7:21                     ` Hardik Prakash
2026-05-19 14:28                       ` Mario Limonciello
2026-05-19 14:39                         ` Bartosz Golaszewski
2026-05-19 14:48                           ` Mario Limonciello
2026-05-19 19:07                             ` Hardik Prakash
2026-05-19 19:49                               ` Hardik Prakash
2026-05-19 20:53                                 ` Mario Limonciello
2026-05-20  5:02                                   ` Hardik Prakash
2026-05-23  7:51                                     ` Hardik Prakash
2026-05-23 12:43                                       ` Mario Limonciello
2026-05-18 14:08 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d5da93e-bbe0-4359-9f17-e3c6b3a5cb34@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=basavaraj.natikar@amd.com \
    --cc=brgl@kernel.org \
    --cc=hardikprakash.official@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox