From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hardik Prakash <hardikprakash.official@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
wsa@kernel.org, mario.limonciello@amd.com, brgl@bgdev.pl,
basavaraj.natikar@amd.com, linus.walleij@linaro.org
Subject: Re: [PATCH v5 0/1] i2c: designware: fix probe ordering for AMD GPIO on Lenovo Yoga 7 14AGP11
Date: Mon, 18 May 2026 17:08:40 +0300 [thread overview]
Message-ID: <agsdaJMAmtefi7tR@ashevche-desk.local> (raw)
In-Reply-To: <20260518122814.8975-1-hardikprakash.official@gmail.com>
On Mon, May 18, 2026 at 05:58:12PM +0530, Hardik Prakash wrote:
> Patch 1/2 (pinctrl-amd GPIO IRQ fix) is already in Linus Walleij's
> tree. This series contains only the i2c-designware probe ordering fix,
> based on top of that commit.
>
> The root cause: i2c_designware probes AMDI0010:02 before pinctrl-amd
> completes, so GPIO 157 (WACF2200 GpioInt per ACPI _CRS) has its
> interrupt bits cleared when the first I2C transaction is attempted,
> causing lost arbitration errors.
>
> A higher-level ACPI devlink approach was investigated in response to
> Bartosz Golaszewski's suggestion. The DSDT has no _DEP object linking
> AMDI0010:02 to AMDI0030:00, so fw_devlink has nothing to act on.
> Setting this up at the ACPI layer would require either a firmware
> change to add _DEP, or a DMI quirk in the ACPI scan path — equally
> quirk-based as the current approach.
>
> v5:
> - Add blank line before #include <linux/acpi.h> (Bartosz Golaszewski)
> - Use scoped_guard(device, gpio_dev) (Bartosz Golaszewski)
Too fast, I have a comment in v4, do you have a chance to read it?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-18 14:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 12:28 [PATCH v5 0/1] i2c: designware: fix probe ordering for AMD GPIO on Lenovo Yoga 7 14AGP11 Hardik Prakash
2026-05-18 12:28 ` [PATCH v5 1/1] " Hardik Prakash
2026-05-18 12:47 ` [PATCH v5 0/1] " Mario Limonciello
2026-05-18 13:40 ` Hardik Prakash
2026-05-18 13:45 ` Mario Limonciello
2026-05-18 14:05 ` Bartosz Golaszewski
2026-05-18 14:08 ` Mario Limonciello
2026-05-18 14:10 ` Bartosz Golaszewski
2026-05-18 14:23 ` Hardik Prakash
2026-05-18 14:26 ` Bartosz Golaszewski
2026-05-18 14:27 ` Andy Shevchenko
2026-05-18 17:22 ` Hardik Prakash
2026-05-18 17:44 ` Mario Limonciello
2026-05-19 7:21 ` Hardik Prakash
2026-05-19 14:28 ` Mario Limonciello
2026-05-19 14:39 ` Bartosz Golaszewski
2026-05-19 14:48 ` Mario Limonciello
2026-05-19 19:07 ` Hardik Prakash
2026-05-19 19:49 ` Hardik Prakash
2026-05-19 20:53 ` Mario Limonciello
2026-05-20 5:02 ` Hardik Prakash
2026-05-23 7:51 ` Hardik Prakash
2026-05-23 12:43 ` Mario Limonciello
2026-05-18 14:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agsdaJMAmtefi7tR@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=basavaraj.natikar@amd.com \
--cc=brgl@bgdev.pl \
--cc=hardikprakash.official@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox