From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Basavaraj Natikar <bnatikar@amd.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Shyam-sundar.S-k@amd.com, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/3] pinctrl: amd: Get and update IOMUX details
Date: Tue, 24 May 2022 14:37:18 +0300 [thread overview]
Message-ID: <YozDbugZc8vXPHU2@lahna> (raw)
In-Reply-To: <e35efb44-6e74-690c-91b6-c8270f624894@amd.com>
Hi,
On Tue, May 24, 2022 at 04:48:03PM +0530, Basavaraj Natikar wrote:
>
> >> +
> >> + status = acpi_walk_namespace(ACPI_TYPE_REGION, sys_bus_handle, ACPI_UINT32_MAX,
> >> + acpi_get_iomux_region, NULL, gpio_dev, NULL);
> >> +
> >> + if (ACPI_FAILURE(status)) {
> >> + dev_err(&gpio_dev->pdev->dev, "Failed to get acpi_get_iomux_region\n");
> >> + return;
> >> + }
> >> +}
> > Oh this looks scary to me, make sure you get the review from the GPIO
> > ACPI experts, Andy Shevchenko and/or Mika Westerberg. (Added on the
> > To: line)
>
> Thanks Linus for the feedback.
>
> Hi Andy/Mika,
>
> Please provide your suggestions for this patch.
If this is about muxing pins, have you looked at the ACPI PinFunction ()
and related descriptors?
next prev parent reply other threads:[~2022-05-24 11:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:40 [PATCH v2 0/3] Enhancements to AMD pinctrl and implementation of AMD pinmux Basavaraj Natikar
2022-05-24 7:40 ` [PATCH v2 1/3] pinctrl: amd: Define and use PINCTRL_GRP Basavaraj Natikar
2022-05-24 9:36 ` Linus Walleij
2022-05-24 14:34 ` Andy Shevchenko
2022-05-24 14:38 ` Andy Shevchenko
2022-05-25 6:05 ` Linus Walleij
2022-05-26 6:27 ` Basavaraj Natikar
2022-05-24 7:40 ` [PATCH v2 2/3] pinctrl: amd: Get and update IOMUX details Basavaraj Natikar
2022-05-24 9:38 ` Linus Walleij
2022-05-24 11:18 ` Basavaraj Natikar
2022-05-24 11:37 ` Mika Westerberg [this message]
2022-05-24 11:52 ` Basavaraj Natikar
2022-05-24 12:07 ` Mika Westerberg
2022-05-24 12:24 ` Basavaraj Natikar
2022-05-24 12:34 ` Mika Westerberg
2022-05-24 13:50 ` Basavaraj Natikar
2022-05-24 16:39 ` Andy Shevchenko
2022-05-25 9:42 ` Basavaraj Natikar
2022-05-25 16:45 ` Andy Shevchenko
2022-05-26 6:30 ` Basavaraj Natikar
2022-05-24 13:06 ` Andy Shevchenko
2022-05-24 7:40 ` [PATCH v2 3/3] pinctrl: amd: Implement pinmux functionality Basavaraj Natikar
2022-05-24 9:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YozDbugZc8vXPHU2@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bnatikar@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox