From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Basavaraj Natikar <bnatikar@amd.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Shyam-sundar.S-k@amd.com, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/3] pinctrl: amd: Get and update IOMUX details
Date: Tue, 24 May 2022 15:34:14 +0300 [thread overview]
Message-ID: <YozQxvHzoiISqjob@lahna> (raw)
In-Reply-To: <c79fc5ce-469d-a547-5485-aa00210db79b@amd.com>
On Tue, May 24, 2022 at 05:54:47PM +0530, Basavaraj Natikar wrote:
> There is no CRS method defined for IOMX/0xFED80D00 in ACPI namespace // IOMX Address Base
> Hence I added additional code to get IOMX memory region.
>
> since _CRS method is used to get GPIO pin base for AMDI0030 in
> pinctrl-amd as below, same is not available for IOMX
>
> Device (GPIO)
> {
> Name (_HID, "AMDI0030") // _HID: Hardware ID
> Name (_CID, "AMDI0030") // _CID: Compatible ID
> Name (_UID, Zero) // _UID: Unique ID
> Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
> {
> Name (RBUF, ResourceTemplate ()
> {
> Interrupt (ResourceConsumer, Level, ActiveLow, Shared, ,, )
> {
> 0x00000007,
> }
> Memory32Fixed (ReadWrite,
> 0xFED81500, // Address Base
> 0x00000400, // Address Length
> )
Is there something preventing you to add it here like below?
Memory32Fixed (ReadWrite, 0xFED80D00 0x00000400)
next prev parent reply other threads:[~2022-05-24 12:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:40 [PATCH v2 0/3] Enhancements to AMD pinctrl and implementation of AMD pinmux Basavaraj Natikar
2022-05-24 7:40 ` [PATCH v2 1/3] pinctrl: amd: Define and use PINCTRL_GRP Basavaraj Natikar
2022-05-24 9:36 ` Linus Walleij
2022-05-24 14:34 ` Andy Shevchenko
2022-05-24 14:38 ` Andy Shevchenko
2022-05-25 6:05 ` Linus Walleij
2022-05-26 6:27 ` Basavaraj Natikar
2022-05-24 7:40 ` [PATCH v2 2/3] pinctrl: amd: Get and update IOMUX details Basavaraj Natikar
2022-05-24 9:38 ` Linus Walleij
2022-05-24 11:18 ` Basavaraj Natikar
2022-05-24 11:37 ` Mika Westerberg
2022-05-24 11:52 ` Basavaraj Natikar
2022-05-24 12:07 ` Mika Westerberg
2022-05-24 12:24 ` Basavaraj Natikar
2022-05-24 12:34 ` Mika Westerberg [this message]
2022-05-24 13:50 ` Basavaraj Natikar
2022-05-24 16:39 ` Andy Shevchenko
2022-05-25 9:42 ` Basavaraj Natikar
2022-05-25 16:45 ` Andy Shevchenko
2022-05-26 6:30 ` Basavaraj Natikar
2022-05-24 13:06 ` Andy Shevchenko
2022-05-24 7:40 ` [PATCH v2 3/3] pinctrl: amd: Implement pinmux functionality Basavaraj Natikar
2022-05-24 9:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YozQxvHzoiISqjob@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bnatikar@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox