From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, krzk@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 2/2] regulator: s5m8767: Convert to GPIO descriptors
Date: Thu, 27 Mar 2025 13:37:16 +0200 [thread overview]
Message-ID: <Z-U4bAMt82SipwuY@smile.fi.intel.com> (raw)
In-Reply-To: <20250327004945.563765-2-peng.fan@oss.nxp.com>
On Thu, Mar 27, 2025 at 08:49:45AM +0800, Peng Fan (OSS) wrote:
> Update the driver to fetch buck_gpio and buck_ds as GPIO descriptors.
> Then drop the usage of 'of_gpio.h' which should be deprecated.
> Based on commit 84618d5e31cf ("regulator: max8997:
> Convert to GPIO descriptors") as a reference to make the changes.
>
> With the quirk fix for s5m8767 in of_gpio_try_fixup_polarity,
> the polarity will be active-high, even if exynos5250 spring DTS
> wrongly use active-low polarity. So using GPIO descriptors,
> it should work as before.
I was a bit trapped by the set_low and set_high callback implementation,
but I think I understood the idea behind and this code does not change
the original logic.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-27 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 0:49 [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767 Peng Fan (OSS)
2025-03-27 0:49 ` [PATCH V2 2/2] regulator: s5m8767: Convert to GPIO descriptors Peng Fan (OSS)
2025-03-27 11:37 ` Andy Shevchenko [this message]
2025-03-27 12:03 ` Mark Brown
2025-03-27 16:54 ` Krzysztof Kozlowski
2025-03-28 7:49 ` Linus Walleij
2025-03-27 8:55 ` [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767 Bartosz Golaszewski
2025-03-27 12:05 ` Mark Brown
2025-03-27 10:15 ` Andy Shevchenko
2025-03-27 10:25 ` Peng Fan
2025-03-28 7:50 ` Linus Walleij
2025-04-07 7:42 ` (subset) " Bartosz Golaszewski
2025-04-07 22:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-U4bAMt82SipwuY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox