From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Peng Fan <peng.fan@nxp.com>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
<linux-sound@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:GPIO
SUBSYSTEM:Keyword:(devm_)?gpio_(request|free|direction|get|set)"
<linux-gpio@vger.kernel.org>,
krzk@kernel.org
Subject: Re: [PATCH] ASoC: codec: ak5386: Convert to GPIO descriptors
Date: Mon, 31 Mar 2025 10:19:12 +0300 [thread overview]
Message-ID: <Z-pB8IQTWKXze6jd@smile.fi.intel.com> (raw)
In-Reply-To: <20250331060359.GA6762@nxa18884-linux>
On Mon, Mar 31, 2025 at 02:03:59PM +0800, Peng Fan wrote:
> On Fri, Mar 28, 2025 at 03:33:11PM +0200, Andy Shevchenko wrote:
> >On Fri, Mar 28, 2025 at 07:39:17PM +0800, Peng Fan (OSS) wrote:
...
> >> The Documentation/devicetree/bindings/sound/ak5386.txt not specify
> >> polarity(this seems bug), so per code and datasheet, I think it
> >> should be active-high. I could add a quirk in gpiolib-of to force
> >> active-high or acitive-low if you think needed.
> >
> >I don't think we need a quirk as long as the default is the same,
> >I mean if the DTS is written without setting polarity, would it be
> >active-high or active-low?
>
> Per current gpio driver, of_gpio_n_cells should at least be 2,
> Not find any driver using 1 in current linux tree.
Yes...
> Without polarity, I think of_xlate will not work as expected.
...and yes, but how is it related to my comment? The default should be sane
to make it work, since there is no in-kernel user with wrong polarity there
is nothing to fix.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-31 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 11:39 [PATCH] ASoC: codec: ak5386: Convert to GPIO descriptors Peng Fan (OSS)
2025-03-28 13:33 ` Andy Shevchenko
2025-03-31 6:03 ` Peng Fan
2025-03-31 7:19 ` Andy Shevchenko [this message]
2025-03-31 11:54 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-pB8IQTWKXze6jd@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox