* [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write
@ 2023-08-25 10:15 Mikhail Kobuk
2023-08-27 18:46 ` Jonathan Neuschäfer
2023-09-12 7:04 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Mikhail Kobuk @ 2023-08-25 10:15 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: Mikhail Kobuk, Linus Walleij, openbmc, linux-gpio, linux-kernel,
lvc-project, Alexey Khoroshilov
Write into 'pctrl->gpio_bank' happens before the check for GPIO index
validity, so out of bounds write may happen.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru>
Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
index 2d1c1652cfd9..8a9961ac8712 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
@@ -1062,13 +1062,13 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
if (ret < 0)
return ret;
- gpio = &pctrl->gpio_bank[reg];
- gpio->pctrl = pctrl;
-
if (reg >= WPCM450_NUM_BANKS)
return dev_err_probe(dev, -EINVAL,
"GPIO index %d out of range!\n", reg);
+ gpio = &pctrl->gpio_bank[reg];
+ gpio->pctrl = pctrl;
+
bank = &wpcm450_banks[reg];
gpio->bank = bank;
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write
2023-08-25 10:15 [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write Mikhail Kobuk
@ 2023-08-27 18:46 ` Jonathan Neuschäfer
2023-09-12 7:04 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2023-08-27 18:46 UTC (permalink / raw)
To: Mikhail Kobuk
Cc: Jonathan Neuschäfer, lvc-project, Linus Walleij,
linux-kernel, linux-gpio, openbmc, Alexey Khoroshilov
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On Fri, Aug 25, 2023 at 01:15:28PM +0300, Mikhail Kobuk wrote:
> Write into 'pctrl->gpio_bank' happens before the check for GPIO index
> validity, so out of bounds write may happen.
Good point.
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Thanks!
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru>
> Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
> drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> index 2d1c1652cfd9..8a9961ac8712 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -1062,13 +1062,13 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
> if (ret < 0)
> return ret;
>
> - gpio = &pctrl->gpio_bank[reg];
> - gpio->pctrl = pctrl;
> -
> if (reg >= WPCM450_NUM_BANKS)
> return dev_err_probe(dev, -EINVAL,
> "GPIO index %d out of range!\n", reg);
>
> + gpio = &pctrl->gpio_bank[reg];
> + gpio->pctrl = pctrl;
> +
> bank = &wpcm450_banks[reg];
> gpio->bank = bank;
>
> --
> 2.42.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write
2023-08-25 10:15 [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write Mikhail Kobuk
2023-08-27 18:46 ` Jonathan Neuschäfer
@ 2023-09-12 7:04 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-09-12 7:04 UTC (permalink / raw)
To: Mikhail Kobuk
Cc: Jonathan Neuschäfer, openbmc, linux-gpio, linux-kernel,
lvc-project, Alexey Khoroshilov
On Fri, Aug 25, 2023 at 12:15 PM Mikhail Kobuk <m.kobuk@ispras.ru> wrote:
> Write into 'pctrl->gpio_bank' happens before the check for GPIO index
> validity, so out of bounds write may happen.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru>
> Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-12 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 10:15 [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write Mikhail Kobuk
2023-08-27 18:46 ` Jonathan Neuschäfer
2023-09-12 7:04 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox