* [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750
@ 2025-04-24 4:47 Maulik Shah
2025-04-24 6:56 ` Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maulik Shah @ 2025-04-24 4:47 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Melody Olvera
Cc: linux-arm-msm, linux-gpio, linux-kernel, Maulik Shah
On newer SoCs intr_target_bit position is at 8 instead of 5. Fix it.
Also add missing intr_wakeup_present_bit and intr_wakeup_enable_bit which
enables forwarding of GPIO interrupts to parent PDC interrupt controller.
Fixes: afe9803e3b82 ("pinctrl: qcom: Add sm8750 pinctrl driver")
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
---
drivers/pinctrl/qcom/pinctrl-sm8750.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8750.c b/drivers/pinctrl/qcom/pinctrl-sm8750.c
index 1af11cd95fb0e69fcc876fe069cc2cd6fd6679fd..b94fb4ee0ec38013d8cde7e45a7d6088a20e3b28 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8750.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8750.c
@@ -46,7 +46,9 @@
.out_bit = 1, \
.intr_enable_bit = 0, \
.intr_status_bit = 0, \
- .intr_target_bit = 5, \
+ .intr_wakeup_present_bit = 6, \
+ .intr_wakeup_enable_bit = 7, \
+ .intr_target_bit = 8, \
.intr_target_kpss_val = 3, \
.intr_raw_status_bit = 4, \
.intr_polarity_bit = 1, \
---
base-commit: 2c9c612abeb38aab0e87d48496de6fd6daafb00b
change-id: 20250423-pinctrl_sm8750-7abd08406675
Best regards,
--
Maulik Shah <maulik.shah@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750
2025-04-24 4:47 [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750 Maulik Shah
@ 2025-04-24 6:56 ` Abel Vesa
2025-04-24 9:39 ` Dmitry Baryshkov
2025-04-24 16:58 ` Melody Olvera
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2025-04-24 6:56 UTC (permalink / raw)
To: Maulik Shah
Cc: Bjorn Andersson, Linus Walleij, Melody Olvera, linux-arm-msm,
linux-gpio, linux-kernel
On 25-04-24 10:17:10, Maulik Shah wrote:
> On newer SoCs intr_target_bit position is at 8 instead of 5. Fix it.
>
> Also add missing intr_wakeup_present_bit and intr_wakeup_enable_bit which
> enables forwarding of GPIO interrupts to parent PDC interrupt controller.
>
> Fixes: afe9803e3b82 ("pinctrl: qcom: Add sm8750 pinctrl driver")
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Nitpick: in commit subject, fix spelling of definition.
With that fixed, LGTM:
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750
2025-04-24 4:47 [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750 Maulik Shah
2025-04-24 6:56 ` Abel Vesa
@ 2025-04-24 9:39 ` Dmitry Baryshkov
2025-04-24 16:58 ` Melody Olvera
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-04-24 9:39 UTC (permalink / raw)
To: Maulik Shah
Cc: Bjorn Andersson, Linus Walleij, Melody Olvera, linux-arm-msm,
linux-gpio, linux-kernel
On Thu, Apr 24, 2025 at 10:17:10AM +0530, Maulik Shah wrote:
> On newer SoCs intr_target_bit position is at 8 instead of 5. Fix it.
>
> Also add missing intr_wakeup_present_bit and intr_wakeup_enable_bit which
> enables forwarding of GPIO interrupts to parent PDC interrupt controller.
>
> Fixes: afe9803e3b82 ("pinctrl: qcom: Add sm8750 pinctrl driver")
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8750.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750
2025-04-24 4:47 [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750 Maulik Shah
2025-04-24 6:56 ` Abel Vesa
2025-04-24 9:39 ` Dmitry Baryshkov
@ 2025-04-24 16:58 ` Melody Olvera
2 siblings, 0 replies; 4+ messages in thread
From: Melody Olvera @ 2025-04-24 16:58 UTC (permalink / raw)
To: Maulik Shah, Bjorn Andersson, Linus Walleij
Cc: linux-arm-msm, linux-gpio, linux-kernel
On 4/23/2025 9:47 PM, Maulik Shah wrote:
> On newer SoCs intr_target_bit position is at 8 instead of 5. Fix it.
>
> Also add missing intr_wakeup_present_bit and intr_wakeup_enable_bit which
> enables forwarding of GPIO interrupts to parent PDC interrupt controller.
>
> Fixes: afe9803e3b82 ("pinctrl: qcom: Add sm8750 pinctrl driver")
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8750.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Melody Olvera <melody.olvera@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-24 16:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-24 4:47 [PATCH] pinctrl: qcom: Fix PINGROUP defination for sm8750 Maulik Shah
2025-04-24 6:56 ` Abel Vesa
2025-04-24 9:39 ` Dmitry Baryshkov
2025-04-24 16:58 ` Melody Olvera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox